Merge lp:~bilalakhtar/ubiquity/fix-492825-2 into lp:ubiquity

[Bilal Akhtar]

This branch fixes bug #492825 .

[Colin Watson (cjwatson)]

Is this really the best way? What if the translation of "Install"
begins with a letter already used as the accelerator key for the
translation of "Back" or "Forward"? I would have thought that the
correct fix was to change the string to "_Install", and permit
translators to select an appropriate accelerator key; that's how
translations for "Back" and "Forward" are handled.

gui/gtk/ubiquity.ui sets the use_underline property to True for the next
widget, so the set_use_underline call is unnecessary.

[Bilal Akhtar (bilalakhtar)]

Colin,
Even I thought of that. But, then we would need to re-generate translation templates. What do you think?

[Colin Watson (cjwatson)]

We aren't in a translation freeze right now and shouldn't shy away from
regenerating translation templates when it's the right thing to do.

[lp:~bilalakhtar/ubiquity/fix-492825-2]

4145. By Bilal Akhtar on 2010-08-02

Modified stuff a bit, thanks Colin

[Bilal Akhtar (bilalakhtar)]

Colin,
please see now.

[Colin Watson (cjwatson)]

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2010-07-30 20:50:29 +0000
+++ debian/changelog	2010-08-02 13:27:45 +0000
@@ -1,5 +1,6 @@
 ubiquity (2.3.4) UNRELEASED; urgency=low
 
+  [ Mario Limonciello ]
   * Also set the custom title when translating widgets.
   * If there is at least one framebuffer device, fallback to fbdev rather
     than vesa for bulletproof X.
@@ -9,6 +10,11 @@
     primarily intended for systems where the installation kernel has known
     graphics problems, but you are solving them in a post installation step.
 
+  [ Bilal Akhtar ]
+  * debian/ubiquity.templates:
+    - Add an underline symbol before the label of the install button
+      to make it accessible with the Alt key. (LP: #492825)
+
  -- Mario Limonciello <[e-mail]>  Thu, 29 Jul 2010 00:05:19 -0500
 
 ubiquity (2.3.3) maverick; urgency=low
 
=== modified file 'debian/ubiquity.templates'
--- debian/ubiquity.templates	2010-07-30 20:50:29 +0000
+++ debian/ubiquity.templates	2010-08-02 13:27:45 +0000
@@ -343,7 +343,7 @@
 Type: text
 # This is used as a button label, and should be translated as an action.
 # Omit the [ ... ] from the translation.
-_Description: Install[ action ]
+_Description: _Install[ action ]
 
 Template: ubiquity/text/step_label
 Type: text