Merge lp:~bfiller/notes-app/fix-keyboard-hide into lp:notes-app

Proposed by Bill Filler
Status: Merged
Approved by: Renato Araujo Oliveira Filho
Approved revision: 124
Merged at revision: 125
Proposed branch: lp:~bfiller/notes-app/fix-keyboard-hide
Merge into: lp:notes-app
Diff against target: 41 lines (+10/-12)
2 files modified
Components/TextDelegate.qml (+0/-12)
NotesApp.qml (+10/-0)
To merge this branch: bzr merge lp:~bfiller/notes-app/fix-keyboard-hide
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Renato Araujo Oliveira Filho (community) Approve
Review via email: mp+166850@code.launchpad.net

Commit message

fix for lp:1182108 keyboard not hiding

Description of the change

fix for lp:1182108 keyboard not hiding

To post a comment you must log in.
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Works as expected.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Components/TextDelegate.qml'
--- Components/TextDelegate.qml 2013-04-30 22:22:15 +0000
+++ Components/TextDelegate.qml 2013-05-31 16:37:39 +0000
@@ -34,16 +34,4 @@
34 textArea.cursorPosition = textArea.text.length34 textArea.cursorPosition = textArea.text.length
35 }35 }
3636
37 Connections {
38 target: Qt.inputMethod
39 onVisibleChanged: {
40 // This event is received by *all* delegates, but we want to defocus
41 // only the current one when the OSK disappear.
42 // We want to defocus because otherwise when the user clicks again on
43 // the text area the OSK will not come up again if the focus is still there.
44 if (!Qt.inputMethod.visible && textArea.activeFocus) {
45 textArea.focus = false;
46 }
47 }
48 }
49}37}
5038
=== modified file 'NotesApp.qml'
--- NotesApp.qml 2013-05-21 15:59:52 +0000
+++ NotesApp.qml 2013-05-31 16:37:39 +0000
@@ -99,6 +99,16 @@
99 focus: true99 focus: true
100 model: dataModel100 model: dataModel
101 }101 }
102
103 Connections {
104 target: Qt.inputMethod
105 onVisibleChanged: {
106 if (!Qt.inputMethod.visible) {
107 noteList.focus = true;
108 }
109 }
110 }
111
102 }112 }
103113
104 function createNewNote() {114 function createNewNote() {

Subscribers

People subscribed via source and target branches