mediaplayer-app

Merge lp:~bfiller/mediaplayer-app/remove-no-display into lp:mediaplayer-app

  1. remove-no-display
  2. Merge into trunk
Proposed by Bill Filler
Status: Merged
Merged at revision: 144
Proposed branch: lp:~bfiller/mediaplayer-app/remove-no-display
Merge into: lp:mediaplayer-app
Diff against target: 10 lines (+0/-1)
1 file modified
data/mediaplayer-app.desktop.in (+0/-1)
To merge this branch: bzr merge lp:~bfiller/mediaplayer-app/remove-no-display
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
PS Jenkins bot continuous-integration Needs Fixing
Loïc Minier Approve
Review via email: mp+188092@code.launchpad.net

Commit message

remove NoDisplay=true so that it can be launched via upstart-app-launch

Description of the change

remove NoDisplay=true so that it can be launched via upstart-app-launch

To post a comment you must log in.
Revision history for this message
Loïc Minier (lool) wrote :

I tested this locally, and it restored Video scope activation.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/mediaplayer-app-autolanding/52/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4129
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/1772
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-saucy-amd64-autolanding/28
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-saucy-armhf-autolanding/28
        deb: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-saucy-armhf-autolanding/28/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-saucy-i386-autolanding/28
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/430
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/4255
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/4255/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1774
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1774/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1476
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1488

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:142
http://jenkins.qa.ubuntu.com/job/mediaplayer-app-ci/119/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4131
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/1774
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-saucy-amd64-ci/55
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-saucy-armhf-ci/55
        deb: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-saucy-armhf-ci/55/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-saucy-i386-ci/55
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/432
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/4257
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/4257/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1776
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1776/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1479
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1491

Click here to trigger a rebuild:
http://s-jenkins:8080/job/mediaplayer-app-ci/119/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/mediaplayer-app-autolanding/53/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4146
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/1806
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-saucy-amd64-autolanding/29
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-saucy-armhf-autolanding/29
        deb: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-saucy-armhf-autolanding/29/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-saucy-i386-autolanding/29
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/447
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/13
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/13/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1808
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1808/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1507
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1519

review: Needs Fixing (continuous-integration)
Revision history for this message
Loïc Minier (lool) wrote :

Ah, the autopilot tests for sceneselector are failing of course...
MismatchError: After 10.0 seconds test on SceneSelector.opacity failed: 1 != dbus.Double(0.0, variant_level=1)

Bill, would you mind commenting these out for now?

Revision history for this message
Loïc Minier (lool) wrote :

That's test_time_display_behavior() and I'm assuming test_show_controls_at_end() is the same issue.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Let's push that directly to trunk to get back uri activation on the image. Loïc is going to log a bug for the AP failing

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/mediaplayer-app.desktop.in'
--- data/mediaplayer-app.desktop.in 2013-09-19 18:37:58 +0000
+++ data/mediaplayer-app.desktop.in 2013-09-27 16:19:21 +0000
@@ -6,6 +6,5 @@
6Exec=mediaplayer-app %u6Exec=mediaplayer-app %u
7Terminal=false7Terminal=false
8Icon=media-player8Icon=media-player
9NoDisplay=true
10X-Ubuntu-Gettext-Domain=mediaplayer-app9X-Ubuntu-Gettext-Domain=mediaplayer-app
11X-Ubuntu-Single-Instance=true10X-Ubuntu-Single-Instance=true

Subscribers

People subscribed via source and target branches