Merge ~bettyl/plainbox-provider-certification-client:add-auto-test-plan into plainbox-provider-certification-client:master

Proposed by Betty Lin
Status: Merged
Approved by: Betty Lin
Approved revision: 0a6c0430c556e7be422718910948a47f0bef6b14
Merged at revision: 912904379519bbf73999356808256abfb218bc9e
Proposed branch: ~bettyl/plainbox-provider-certification-client:add-auto-test-plan
Merge into: plainbox-provider-certification-client:master
Diff against target: 96 lines (+90/-0)
1 file modified
units/client-cert-auto.pxu (+90/-0)
Reviewer Review Type Date Requested Status
Jerry Kao (community) Approve
Jonathan Cave (community) Approve
Betty Lin (community) Needs Resubmitting
Sylvain Pineau Pending
Review via email: mp+377138@code.launchpad.net

Description of the change

Engineer would like to nest auto test plan from us, so move it to plainbox-provider-certification-client.

To post a comment you must log in.
Revision history for this message
Jonathan Cave (jocave) wrote :

Could you provide a bit more info about where the test plan was moved from so someone reviewing can make a comparison / has an indication of the history?

review: Needs Information
Revision history for this message
Betty Lin (bettyl) wrote :

@Jonathan

The auto test plan came from oem-qa-checkbox: https://git.launchpad.net/~oem-qa/oem-qa-checkbox/+git/oem-plainbox/tree/units/oem-generic-auto.pxu , it runs on pc project for a while.

Here is the document that engineer's request to move the auto test plan to plainbox-provider-certification-client.
https://docs.google.com/document/d/1JKzndCLUKxxUYTNJExGWT74OUXPYileDs1M_MO5CgyI/edit?disco=AAAAEB1NC7Y

Revision history for this message
Jonathan Cave (jocave) wrote :

Thanks having the links in the MR helps with auditing.

I think it would appropriate to be more descriptive in _name & _description - for example if these where to shown in the test plan browser of checkbox just "Generic Auto" really tells you very little about what the test plan is. The description could indicate where it is likely to be used something like "the default set of automated tests for PC OEM and Sanity testing"..

Could you come up with something?

Revision history for this message
Jerry Kao (jerry.kao) wrote :

My suggestion

_name: Fully Automatic Client Certification Tests

_description: This test plan covered most of fully automatic tests in client certification test plan and excludes the tests depend on manual tests. No user interactions are needed to complete this test plan. It's available for auto-regression and auto-sanity tests.

Revision history for this message
Betty Lin (bettyl) wrote :

@Jonathan, based on Jerry's comment, update the test plan.

review: Needs Resubmitting
Revision history for this message
Jonathan Cave (jocave) wrote :

Thanks, looks good to me

For future reference, the description field can use indentation along with newline characters to avoid very long lines.

review: Approve
Revision history for this message
Jerry Kao (jerry.kao) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/units/client-cert-auto.pxu b/units/client-cert-auto.pxu
0new file mode 1006440new file mode 100644
index 0000000..c228620
--- /dev/null
+++ b/units/client-cert-auto.pxu
@@ -0,0 +1,90 @@
1id: client-cert-auto
2_name: Fully Automatic Client Certification Tests
3unit: test plan
4_description: This test plan covered most of fully automatic tests
5 in client certification test plan and excludes the tests depend on
6 manual tests. No user interactions are needed to complete this test plan.
7 It's available for auto-regression and auto-sanity tests.
8include:
9 com.canonical.certification::audio/alsa_record_playback_automated
10 com.canonical.certification::bluetooth/detect-output
11 com.canonical.certification::camera/detect
12 com.canonical.certification::camera/multiple-resolution-images
13 com.canonical.certification::cpu/scaling_test
14 com.canonical.certification::cpu/scaling_test-log-attach
15 com.canonical.certification::cpu/offlining_test
16 com.canonical.certification::cpu/topology
17 com.canonical.certification::disk/read_performance_.*
18 com.canonical.certification::graphics/xorg-version
19 com.canonical.certification::graphics/1_gl_support_.*
20 com.canonical.certification::graphics/xorg-failsafe
21 com.canonical.certification::graphics/xorg-process
22 com.canonical.certification::graphics/2_auto_switch_card_.*
23 com.canonical.certification::graphics/2_valid_opengl_renderer_.*
24 com.canonical.certification::graphics/2_driver_version_.*
25 com.canonical.certification::graphics/2_gl_support_.*
26 com.canonical.certification::suspend/2_resolution_before_suspend_.*_auto
27 com.canonical.certification::install/apt-get-gets-updates
28 com.canonical.certification::mediacard/sd-preinserted
29 com.canonical.certification::memory/info
30 com.canonical.certification::ethernet/detect
31 com.canonical.certification::ethernet/info_automated
32 com.canonical.certification::miscellanea/dkms_build_validation
33 com.canonical.certification::networking/http
34 com.canonical.certification::networking/gateway_ping
35 com.canonical.certification::power-management/tickless_idle
36 com.canonical.certification::power-management/rtc
37 com.canonical.certification::power-management/fwts_wakealarm
38 com.canonical.certification::power-management/fwts_wakealarm-log-attach
39 com.canonical.certification::usb/detect
40 com.canonical.certification::usb/storage-preinserted
41 com.canonical.certification::wireless/nm_connection_save_.*
42 com.canonical.certification::wireless/wireless_scanning_.*
43 com.canonical.certification::wireless/wireless_connection_wpa_bg_nm_.*
44 com.canonical.certification::wireless/wireless_connection_open_bg_nm_.*
45 com.canonical.certification::wireless/wireless_connection_wpa_n_nm_.*
46 com.canonical.certification::wireless/wireless_connection_open_n_nm_.*
47 com.canonical.certification::wireless/nm_connection_restore_.*
48 com.canonical.certification::suspend/audio_before_suspend
49 com.canonical.certification::suspend/bluetooth_obex_browse_before_suspend
50 com.canonical.certification::suspend/cpu_before_suspend
51 com.canonical.certification::suspend/network_before_suspend
52 com.canonical.certification::suspend/memory_before_suspend
53 com.canonical.certification::suspend/suspend_advanced_auto
54 com.canonical.certification::suspend/suspend-single-log-attach
55 com.canonical.certification::suspend/audio_after_suspend_auto
56 com.canonical.certification::suspend/2_suspend_after_switch_to_card_.*_auto
57 com.canonical.certification::suspend/2_suspend-time-check_.*_auto
58 com.canonical.certification::suspend/2_suspend-single-log-attach_.*_auto
59 com.canonical.certification::suspend/2_gl_support_after_suspend_.*_auto
60 com.canonical.certification::suspend/2_driver_version_after_suspend_.*_auto
61 com.canonical.certification::suspend/2_resolution_after_suspend_.*_auto
62 com.canonical.certification::graphics/1_auto_switch_card_.*
63 com.canonical.certification::suspend/1_resolution_before_suspend_.*_auto
64 com.canonical.certification::suspend/1_suspend_after_switch_to_card_.*_auto
65 com.canonical.certification::suspend/1_suspend-time-check_.*_auto
66 com.canonical.certification::suspend/1_suspend-single-log-attach_.*_auto
67 com.canonical.certification::suspend/1_gl_support_after_suspend_.*_auto
68 com.canonical.certification::suspend/1_driver_version_after_suspend_.*_auto
69 com.canonical.certification::suspend/1_resolution_after_suspend_.*_auto
70 com.canonical.certification::suspend/network_resume_time_auto
71 com.canonical.certification::suspend/wifi_resume_time_auto
72 com.canonical.certification::suspend/usb_storage_preinserted_after_suspend
73 com.canonical.certification::suspend/record_playback_after_suspend_auto
74 com.canonical.certification::suspend/bluetooth_obex_browse_after_suspend_auto
75 com.canonical.certification::suspend/cpu_after_suspend_auto
76 com.canonical.certification::suspend/memory_after_suspend_auto
77 com.canonical.certification::after-suspend-wireless/nm_connection_save_.*
78 com.canonical.certification::after-suspend-wireless/wireless_connection_wpa_bg_nm_.*
79 com.canonical.certification::after-suspend-wireless/wireless_connection_open_bg_nm_.*
80 com.canonical.certification::after-suspend-wireless/wireless_connection_wpa_n_nm_.*
81 com.canonical.certification::after-suspend-wireless/wireless_connection_open_n_nm_.*
82 com.canonical.certification::after-suspend-wireless/nm_connection_restore_.*
83 com.canonical.certification::suspend/gpu_lockup_after_suspend
84 com.canonical.certification::recovery_info_attachment
85nested_part:
86 com.canonical.certification::submission-cert-full
87 com.canonical.certification::info-attachment-cert-full
88bootstrap_include:
89 com.canonical.certification::device
90 com.canonical.certification::graphics_card

Subscribers

People subscribed via source and target branches

to all changes: