Merge lp:~bcbc/wubi/lp694242-precise into lp:~ubuntu-installer/wubi/precise

[bcbc]

This patch lets Wubi check whether Windows boots using EFI and, if so, prevents further processing.

The technique used is to examine the output of BCDEDIT for the presence of either bootmgfw.efi or winload.efi. I'm not entirely happy with this technique: ideally there would be a registry entry that is conclusive, but it works on BCDEDIT output I've seen from EFI systems ( http://ubuntuforums.org/showthread.php?t=2070760&p=12296995&viewfull=1#post12296995 )

The check is performed prior to making any changes, so there is no need to download anything or uninstall once it has been determined that Windows boots in is in EFI mode.

I have tested this patch to confirm that it installs as usual on BIOS firmware (tested on Windows 8). The same patch on 13.04 has been tested on Windows XP as well.

I haven't tested it on an EFI computer as I don't own one, but I created a test version that was identical except it searched for a string that happened to exist in my BCDEDIT output.
Ideally, we could build the wubi-r274.exe and then make a call for some community testing to confirm positive tests.

The wubi-12.04-rev274.log file contains the additional line if not using EFI:
04-23 12:10 DEBUG WindowsBackend: EFI boot = False

or if using EFI the following lines:
04-23 12:07 DEBUG WindowsBackend: EFI boot = True
...
04-23 12:08 ERROR root: Wubi does not currently support EFI

There is also a Windows popup with the message: Wubi does not currently support EFI

[bcbc (bcbc)]

I've tested this in VMWare Player with Windows installed in EFI mode and it works as expected.

There's no cleanup, downloading, etc. It detects EFI, gives a message and quits.

Unmerged revisions

274. By bcbc on 2013-04-23

Prevent installation on EFI systems (LP: #694242)

=== modified file 'debian/changelog'
--- debian/changelog	2013-04-17 12:52:58 +0000
+++ debian/changelog	2013-04-23 19:15:33 +0000
@@ -1,3 +1,9 @@
+wubi (12.04.2) precise; urgency=low
+
+  * Prevent installation on EFI systems (LP: #694242) 
+
+ -- bcbc <[e-mail]>  Tue, 23 Apr 2013 11:44:12 -0700
+
 wubi (12.04.1) UNRELEASED; urgency=low
 
   * Set kernel to vmlinuz.efi for amd64 architecture (LP: #1134770) 
 
=== modified file 'src/wubi/application.py'
--- src/wubi/application.py	2011-10-06 14:59:42 +0000
+++ src/wubi/application.py	2013-04-23 19:15:33 +0000
@@ -151,6 +151,11 @@
                 log.error(message)
                 self.get_frontend().show_error_message(message)
                 self.quit()
+        if self.info.efi:
+            message = "Wubi does not currently support EFI"
+            log.error(message)
+            self.get_frontend().show_error_message(message)
+            self.quit()
         log.info("Running the installer...")
         self.frontend = self.get_frontend()
         self.frontend.show_installation_settings()
 
=== modified file 'src/wubi/backends/win32/backend.py'
--- src/wubi/backends/win32/backend.py	2012-02-24 07:44:21 +0000
+++ src/wubi/backends/win32/backend.py	2013-04-23 19:15:33 +0000
@@ -72,6 +72,7 @@
         self.info.drives = self.get_drives()
         drives = [(d.path[:2].lower(), d) for d in self.info.drives]
         self.info.drives_dict = dict(drives)
+        self.info.efi = self.check_EFI()
 
     def select_target_dir(self):
         target_dir = join_path(self.info.target_drive.path, self.info.distro.installation_dir)
@@ -548,6 +549,27 @@
             'HKEY_LOCAL_MACHINE',
             self.info.registry_key)
 
+    def check_EFI(self):
+        efi = False
+        if self.info.bootloader == 'vista':
+            bcdedit = join_path(os.getenv('SystemDrive'), 'bcdedit.exe')
+            if not os.path.isfile(bcdedit):
+                bcdedit = join_path(os.environ['systemroot'], 'sysnative', 'bcdedit.exe')
+            if not os.path.isfile(bcdedit):
+                bcdedit = join_path(os.environ['systemroot'], 'System32', 'bcdedit.exe')
+            if not os.path.isfile(bcdedit):
+                log.error("Cannot find bcdedit")
+                return False
+            command = [bcdedit, '/enum']
+            result = run_command(command)
+            result = result.lower()
+            if "bootmgfw.efi" in result:
+                efi = True
+            if "winload.efi" in result:
+                efi = True
+        log.debug('EFI boot = %s' % efi)
+        return efi
+
     def modify_bootloader(self, associated_task):
         for drive in self.info.drives:
             if drive.type not in ('removable', 'hd'):