Merge lp:~barry/whoopsie/lp1390627 into lp:whoopsie

[Barry Warsaw]

Whoopsie was converting all "control characters" (i.e. less than ASCII SPACE) to a '?'. This just modifies the conditional so that it won't convert TAB characters. It appears that bson still does the right thing.

When viewed in a web page, you won't see the TABs but rather than e.g. convert them to a space, I figured since they are preserved across the wire, might as well preserve the original char.

[Brian Murray (brian-murray)]

Wow, I thought I'd looked through whoopsie when I noticed the bug. Thanks for fixing this, feel free to upload it.

[Barry Warsaw (barry)]

Done!

=== modified file 'src/whoopsie.c'
--- src/whoopsie.c	2015-11-03 21:30:06 +0000
+++ src/whoopsie.c	2016-03-17 20:28:55 +0000
@@ -416,8 +416,8 @@
             memcpy (value_p, p, value_length);
             value_p[value_length] = '\0';
             for (char *c = value_p; c < value_p + value_length; c++)
-                /* If c is a control character. */
-                if (*c >= '\0' && *c < ' ')
+                /* If c is a control character but not TAB. */
+                if (*c != '\t' && *c >= '\0' && *c < ' ')
                     *c = '?';
             value_p += value_length;
             g_hash_table_insert (hash_table, key, value ? value : "");