Merge lp:~barry/ubuntu/natty/winpdb/bug-761131 into lp:ubuntu/natty/winpdb

Proposed by Barry Warsaw
Status: Rejected
Rejected by: Colin Watson
Proposed branch: lp:~barry/ubuntu/natty/winpdb/bug-761131
Merge into: lp:ubuntu/natty/winpdb
Diff against target: 479 lines (+161/-179)
9 files modified
.hg_archival.txt (+2/-0)
.hgtags (+2/-0)
PKG-INFO (+0/-13)
README.txt (+1/-1)
debian/changelog (+7/-0)
debian/watch (+1/-2)
rpdb2.py (+141/-156)
setup.py (+1/-1)
winpdb.py (+6/-6)
To merge this branch: bzr merge lp:~barry/ubuntu/natty/winpdb/bug-761131
Reviewer Review Type Date Requested Status
Luke Yelavich (community) Needs Information
Ubuntu branches Pending
Review via email: mp+57787@code.launchpad.net

Description of the change

bzr merge-upstream with new debian/watch file.

To post a comment you must log in.
13. By Barry Warsaw

Debian still has 1.4.6-2

Revision history for this message
Luke Yelavich (themuso) wrote :

Barry, since Natty is now released, do you think this is SRU worthy? I've only glanced briefly at it but am not sure myself.

Thanks.

review: Needs Information
Revision history for this message
Barry Warsaw (barry) wrote :

Hi Luke. I've asked for input from the bug OP, and the Debian maintainer of the package. For now I've marked the bug Incomplete. I don't know myself because I don't use it, and it doesn't have many rdepends, so unless/until we hear about a strong need from others, let's not pursue an SRU for this.

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

This is now marked Fix Released in the bug since Oneiric and Debian have 1.4.8-1.

Revision history for this message
Colin Watson (cjwatson) wrote :

Rejected per the comments above and dholbach's request.

Revision history for this message
Barry Warsaw (barry) wrote :

WFM! Thanks.

Unmerged revisions

13. By Barry Warsaw

Debian still has 1.4.6-2

12. By Barry Warsaw

* debian/watch: Downloads are now on code.google.com.
* New upstream release. (LP: #761131)

11. By Barry Warsaw

Downloads are now on code.google.com.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added file '.hg_archival.txt'
--- .hg_archival.txt 1970-01-01 00:00:00 +0000
+++ .hg_archival.txt 2011-04-21 21:18:39 +0000
@@ -0,0 +1,2 @@
1repo: f88e6e3493b83efb388dae63f265b7c8495d2453
2node: 0aed109de5d171c00dbab20a1e4631d321ba5233
03
=== added file '.hgtags'
--- .hgtags 1970-01-01 00:00:00 +0000
+++ .hgtags 2011-04-21 21:18:39 +0000
@@ -0,0 +1,2 @@
122ebb952cad2e4c6f2612484711dfcf044a670d7 winpdb-1.4.6
24803baa67c54c607093ef3e0f7119486203a11ba winpdb-1.4.6 retag!
03
=== removed file 'PKG-INFO'
--- PKG-INFO 2009-04-19 14:46:16 +0000
+++ PKG-INFO 1970-01-01 00:00:00 +0000
@@ -1,13 +0,0 @@
1Metadata-Version: 1.0
2Name: winpdb
3Version: 1.4.6
4Summary: A platform independent GPL Python debugger.
5Home-page: http://www.winpdb.org/
6Author: Nir Aides
7Author-email: nir@winpdb.org
8License: GNU GPL
9Description: Winpdb is a platform independent GPL Python debugger
10 with support for multiple threads, namespace modification,
11 embedded debugging, encrypted communication
12 and is up to 20 times faster than pdb.
13Platform: any
140
=== modified file 'README.txt'
--- README.txt 2009-04-19 14:46:16 +0000
+++ README.txt 2011-04-21 21:18:39 +0000
@@ -6,7 +6,7 @@
6Contact: Nir Aides6Contact: Nir Aides
7Email: nir@winpdb.org7Email: nir@winpdb.org
8Website: http://www.winpdb.org/8Website: http://www.winpdb.org/
9Version: 1.4.69Version: 1.4.8
1010
1111
1212
1313
=== modified file 'debian/changelog'
--- debian/changelog 2009-10-01 22:27:05 +0000
+++ debian/changelog 2011-04-21 21:18:39 +0000
@@ -1,3 +1,10 @@
1winpdb (1.4.8-0ubuntu1) natty; urgency=low
2
3 * debian/watch: Downloads are now on code.google.com.
4 * New upstream release. (LP: #761131)
5
6 -- Barry Warsaw <barry@ubuntu.com> Thu, 14 Apr 2011 17:29:44 -0400
7
1winpdb (1.4.6-2) unstable; urgency=low8winpdb (1.4.6-2) unstable; urgency=low
29
3 [ Severin Heiniger]10 [ Severin Heiniger]
411
=== modified file 'debian/watch'
--- debian/watch 2007-10-08 20:39:23 +0000
+++ debian/watch 2011-04-21 21:18:39 +0000
@@ -1,5 +1,4 @@
1# Compulsory line, this is a version 3 file1# Compulsory line, this is a version 3 file
2version=32version=3
33
4http://sf.net/winpdb/winpdb-(.*)\.tar\.gz4http://code.google.com/p/winpdb/downloads/detail?name=winpdb-1.4.8.tar.gz&can=2&q= http://winpdb.googlecode.com/files/winpdb-(.*).tar.gz
5
65
=== modified file 'rpdb2.py'
--- rpdb2.py 2009-04-19 14:46:16 +0000
+++ rpdb2.py 2011-04-21 21:18:39 +0000
@@ -1,7 +1,7 @@
1#! /usr/bin/env python1#! /usr/bin/env python
22
3"""3"""
4 rpdb2.py - version 2.4.64 rpdb2.py - version 2.4.8
55
6 A remote Python debugger for CPython6 A remote Python debugger for CPython
77
@@ -24,7 +24,7 @@
2424
25COPYRIGHT_NOTICE = """Copyright (C) 2005-2009 Nir Aides"""25COPYRIGHT_NOTICE = """Copyright (C) 2005-2009 Nir Aides"""
2626
27CREDITS_NOTICE = """This project is waiting for your contribution and support."""27CREDITS_NOTICE = """Work on version 2.4.8 was sponsored by Investortools, Inc."""
2828
29LICENSE_NOTICE = """29LICENSE_NOTICE = """
30This program is free software; you can redistribute it and/or modify it 30This program is free software; you can redistribute it and/or modify it
@@ -539,9 +539,9 @@
539539
540540
541541
542VERSION = (2, 4, 6, 0, 'Tychod')542VERSION = (2, 4, 8, 0, 'Tychod')
543RPDB_TITLE = "RPDB 2.4.6 - Tychod"543RPDB_TITLE = "RPDB 2.4.8 - Tychod"
544RPDB_VERSION = "RPDB_2_4_6"544RPDB_VERSION = "RPDB_2_4_8"
545RPDB_COMPATIBILITY_VERSION = "RPDB_2_4_0"545RPDB_COMPATIBILITY_VERSION = "RPDB_2_4_0"
546546
547547
@@ -2191,8 +2191,12 @@
21912191
21922192
21932193
2194g_safe_base64_to = string.maketrans(as_bytes('/+='), as_bytes('_-#'))2194if is_py3k():
2195g_safe_base64_from = string.maketrans(as_bytes('_-#'), as_bytes('/+='))2195 g_safe_base64_to = bytes.maketrans(as_bytes('/+='), as_bytes('_-#'))
2196 g_safe_base64_from = bytes.maketrans(as_bytes('_-#'), as_bytes('/+='))
2197else:
2198 g_safe_base64_to = string.maketrans(as_bytes('/+='), as_bytes('_-#'))
2199 g_safe_base64_from = string.maketrans(as_bytes('_-#'), as_bytes('/+='))
21962200
21972201
21982202
@@ -3962,7 +3966,7 @@
39623966
3963 fd = os.open(path, os.O_WRONLY | os.O_CREAT, int('0600', 8))3967 fd = os.open(path, os.O_WRONLY | os.O_CREAT, int('0600', 8))
3964 3968
3965 os.write(fd, _rpdb2_pwd)3969 os.write(fd, as_bytes(_rpdb2_pwd))
3966 os.close(fd)3970 os.close(fd)
3967 3971
3968 3972
@@ -9967,156 +9971,93 @@
99679971
99689972
99699973
9970if not is_py3k():9974#
9971 #9975# MOD
9972 # MOD9976#
9973 #9977class CTimeoutHTTPConnection(httplib.HTTPConnection):
9974 class CTimeoutHTTPConnection(httplib.HTTPConnection):9978 """
9975 """9979 Modification of httplib.HTTPConnection with timeout for sockets.
9976 Modification of httplib.HTTPConnection with timeout for sockets.9980 """
9977 """9981
99789982 _rpdb2_timeout = PING_TIMEOUT
9979 _rpdb2_timeout = PING_TIMEOUT
9980
9981 def connect(self):
9982 """Connect to the host and port specified in __init__."""
9983 msg = "getaddrinfo returns an empty list"
9984 for res in socket.getaddrinfo(self.host, self.port, 0,
9985 socket.SOCK_STREAM):
9986 af, socktype, proto, canonname, sa = res
9987 try:
9988 self.sock = socket.socket(af, socktype, proto)
9989 self.sock.settimeout(self._rpdb2_timeout)
9990 if self.debuglevel > 0:
9991 print_debug("connect: (%s, %s)" % (self.host, self.port))
9992 self.sock.connect(sa)
9993 except socket.error:
9994 msg = sys.exc_info()[1]
9995 if self.debuglevel > 0:
9996 print_debug('connect fail: ' + repr((self.host, self.port)))
9997 if self.sock:
9998 self.sock.close()
9999 self.sock = None
10000 continue
10001 break
10002 if not self.sock:
10003 raise socket.error(msg)
10004
10005
10006
10007 #
10008 # MOD
10009 #
10010 class CLocalTimeoutHTTPConnection(CTimeoutHTTPConnection):
10011 """
10012 Modification of httplib.HTTPConnection with timeout for sockets.
10013 """
10014
10015 _rpdb2_timeout = LOCAL_TIMEOUT
10016
10017
10018
10019 #
10020 # MOD
10021 #
10022 class CTimeoutHTTP(httplib.HTTP):
10023 """
10024 Modification of httplib.HTTP with timeout for sockets.
10025 """
10026
10027 _connection_class = CTimeoutHTTPConnection
10028
10029
10030
10031 #
10032 # MOD
10033 #
10034 class CLocalTimeoutHTTP(httplib.HTTP):
10035 """
10036 Modification of httplib.HTTP with timeout for sockets.
10037 """
10038
10039 _connection_class = CLocalTimeoutHTTPConnection
10040
10041 9983
10042 9984 def connect(self):
10043 #9985 """Connect to the host and port specified in __init__."""
10044 # MOD9986
10045 #9987 # New Python version of connect().
10046 class CTimeoutTransport(xmlrpclib.Transport):9988 if hasattr(self, 'timeout'):
10047 """9989 self.timeout = self._rpdb2_timeout
10048 Modification of xmlrpclib.Transport with timeout for sockets.9990 return httplib.HTTPConnection.connect(self)
10049 """9991
10050 9992 # Old Python version of connect().
10051 def make_connection(self, host):9993 msg = "getaddrinfo returns an empty list"
10052 # create a HTTP connection object from a host descriptor9994 for res in socket.getaddrinfo(self.host, self.port, 0,
10053 host, extra_headers, x509 = self.get_host_info(host)9995 socket.SOCK_STREAM):
10054 return CTimeoutHTTP(host)9996 af, socktype, proto, canonname, sa = res
100559997 try:
10056 9998 self.sock = socket.socket(af, socktype, proto)
10057 9999 self.sock.settimeout(self._rpdb2_timeout)
10058 #10000 if self.debuglevel > 0:
10059 # MOD10001 print_debug("connect: (%s, %s)" % (self.host, self.port))
10060 #10002 self.sock.connect(sa)
10061 class CLocalTimeoutTransport(xmlrpclib.Transport):10003 except socket.error:
10062 """10004 msg = sys.exc_info()[1]
10063 Modification of xmlrpclib.Transport with timeout for sockets.10005 if self.debuglevel > 0:
10064 """10006 print_debug('connect fail: ' + repr((self.host, self.port)))
10065 10007 if self.sock:
10066 def make_connection(self, host):10008 self.sock.close()
10067 # create a HTTP connection object from a host descriptor10009 self.sock = None
10068 host, extra_headers, x509 = self.get_host_info(host)10010 continue
10069 return CLocalTimeoutHTTP(host)10011 break
1007010012 if not self.sock:
10013 raise socket.error(msg)
10014
10015
10016
10017#
10018# MOD
10019#
10020class CLocalTimeoutHTTPConnection(CTimeoutHTTPConnection):
10021 """
10022 Modification of httplib.HTTPConnection with timeout for sockets.
10023 """
10024
10025 _rpdb2_timeout = LOCAL_TIMEOUT
10026
10027
10028
10029if is_py3k():
10030 class httplib_HTTP(object):
10031 pass
10071else:10032else:
10072 #10033 httplib_HTTP = httplib.HTTP
10073 # MOD10034
10074 #10035
10075 class CTimeoutTransport(xmlrpclib.Transport):10036
10076 """10037#
10077 Modification of xmlrpclib.Transport with timeout for sockets.10038# MOD
10078 """10039#
10079 10040class CTimeoutHTTP(httplib_HTTP):
10080 def send_request(self, host, handler, request_body, debug):10041 """
10081 host, extra_headers, x509 = self.get_host_info(host)10042 Modification of httplib.HTTP with timeout for sockets.
10082 connection = httplib.HTTPConnection(host, timeout = PING_TIMEOUT)10043 """
10083 if debug:10044
10084 connection.set_debuglevel(1)10045 _connection_class = CTimeoutHTTPConnection
10085 headers = {}10046
10086 if extra_headers:10047
10087 for key, val in extra_headers:10048
10088 header[key] = val10049#
10089 headers["Content-Type"] = "text/xml"10050# MOD
10090 headers["User-Agent"] = self.user_agent10051#
10091 connection.request("POST", handler, request_body, headers)10052class CLocalTimeoutHTTP(httplib_HTTP):
10092 return connection10053 """
1009310054 Modification of httplib.HTTP with timeout for sockets.
10094 10055 """
10095 10056
10096 #10057 _connection_class = CLocalTimeoutHTTPConnection
10097 # MOD10058
10098 #10059
10099 class CLocalTimeoutTransport(xmlrpclib.Transport):10060
10100 """
10101 Modification of xmlrpclib.Transport with timeout for sockets.
10102 """
10103
10104 def send_request(self, host, handler, request_body, debug):
10105 host, extra_headers, x509 = self.get_host_info(host)
10106 connection = httplib.HTTPConnection(host, timeout = LOCAL_TIMEOUT)
10107 if debug:
10108 connection.set_debuglevel(1)
10109 headers = {}
10110 if extra_headers:
10111 for key, val in extra_headers:
10112 header[key] = val
10113 headers["Content-Type"] = "text/xml"
10114 headers["User-Agent"] = self.user_agent
10115 connection.request("POST", handler, request_body, headers)
10116 return connection
10117
10118
10119
10120#10061#
10121# MOD10062# MOD
10122#10063#
@@ -10126,6 +10067,24 @@
10126 bug.10067 bug.
10127 """10068 """
10128 10069
10070 _connection_class = httplib.HTTPConnection
10071 _connection_class_old = httplib_HTTP
10072
10073
10074 def make_connection(self, host):
10075 # New Python version of connect().
10076 # However, make_connection is hacked to always create a new connection
10077 # Otherwise all threads use single connection and crash.
10078 if hasattr(self, '_connection'):
10079 chost, self._extra_headers, x509 = self.get_host_info(host)
10080 return self._connection_class(chost)
10081
10082 # Old Python version of connect().
10083 # create a HTTP connection object from a host descriptor
10084 host, extra_headers, x509 = self.get_host_info(host)
10085 return self._connection_class_old(host)
10086
10087
10129 def __parse_response(self, file, sock):10088 def __parse_response(self, file, sock):
10130 # read response from input file/socket, and parse it10089 # read response from input file/socket, and parse it
1013110090
@@ -10153,6 +10112,32 @@
1015310112
1015410113
10155 10114
10115#
10116# MOD
10117#
10118class CTimeoutTransport(CLocalTransport):
10119 """
10120 Modification of xmlrpclib.Transport with timeout for sockets.
10121 """
10122
10123 _connection_class = CTimeoutHTTPConnection
10124 _connection_class_old = CTimeoutHTTP
10125
10126
10127
10128#
10129# MOD
10130#
10131class CLocalTimeoutTransport(CLocalTransport):
10132 """
10133 Modification of xmlrpclib.Transport with timeout for sockets.
10134 """
10135
10136 _connection_class = CLocalTimeoutHTTPConnection
10137 _connection_class_old = CLocalTimeoutHTTP
10138
10139
10140
10156class CSession:10141class CSession:
10157 """10142 """
10158 Basic class that communicates with the debuggee server.10143 Basic class that communicates with the debuggee server.
1015910144
=== modified file 'setup.py'
--- setup.py 2009-04-19 14:46:16 +0000
+++ setup.py 2011-04-21 21:18:39 +0000
@@ -51,7 +51,7 @@
5151
52setup(52setup(
53 name = 'winpdb',53 name = 'winpdb',
54 version = '1.4.6',54 version = '1.4.8',
55 description = 'A platform independent GPL Python debugger.',55 description = 'A platform independent GPL Python debugger.',
56 long_description = LONG_DESC,56 long_description = LONG_DESC,
57 author = 'Nir Aides',57 author = 'Nir Aides',
5858
=== modified file 'winpdb.py'
--- winpdb.py 2009-04-19 14:46:16 +0000
+++ winpdb.py 2011-04-21 21:18:39 +0000
@@ -40,7 +40,7 @@
40See the GNU General Public License for more details.40See the GNU General Public License for more details.
4141
42Credits:42Credits:
43This project is waiting for your contribution and support."""43Work on version 1.4.8 was sponsored by Investortools, Inc."""
4444
45LICENSE_NOTICE = """45LICENSE_NOTICE = """
46This program is free software; you can redistribute it and/or modify it 46This program is free software; you can redistribute it and/or modify it
@@ -495,9 +495,9 @@
495TLC_HEADER_REPR = "Repr"495TLC_HEADER_REPR = "Repr"
496TLC_HEADER_TYPE = "Type"496TLC_HEADER_TYPE = "Type"
497497
498VERSION = (1, 4, 6, 0, 'Tychod')498VERSION = (1, 4, 8, 0, 'Tychod')
499WINPDB_TITLE = "Winpdb 1.4.6 - Tychod"499WINPDB_TITLE = "Winpdb 1.4.8 - Tychod"
500WINPDB_VERSION = "WINPDB_1_4_6"500WINPDB_VERSION = "WINPDB_1_4_8"
501501
502WINPDB_SIZE = "winpdb_size"502WINPDB_SIZE = "winpdb_size"
503WINPDB_MAXIMIZE = "winpdb_maximize"503WINPDB_MAXIMIZE = "winpdb_maximize"
@@ -4650,8 +4650,8 @@
46504650
46514651
4652def main():4652def main():
4653 if rpdb2.get_version() != "RPDB_2_4_6":4653 if rpdb2.get_version() != "RPDB_2_4_8":
4654 rpdb2._print(STR_ERROR_INTERFACE_COMPATIBILITY % ("RPDB_2_4_6", rpdb2.get_version()))4654 rpdb2._print(STR_ERROR_INTERFACE_COMPATIBILITY % ("RPDB_2_4_8", rpdb2.get_version()))
4655 return4655 return
4656 4656
4657 return rpdb2.main(StartClient, WINPDB_TITLE)4657 return rpdb2.main(StartClient, WINPDB_TITLE)

Subscribers

People subscribed via source and target branches

to all changes: