Merge lp:~barry/mailman/lp1435941 into lp:mailman

Proposed by Barry Warsaw
Status: Rejected
Rejected by: Barry Warsaw
Proposed branch: lp:~barry/mailman/lp1435941
Merge into: lp:mailman
Diff against target: 70 lines (+11/-2)
5 files modified
src/mailman/database/alembic/versions/2bb9b382198_workflow_state_table.py (+3/-1)
src/mailman/database/alembic/versions/46e92facee7_add_serverowner_domainowner.py (+1/-0)
src/mailman/docs/RELEASENOTES.rst (+4/-0)
src/mailman/model/user.py (+1/-0)
src/mailman/model/workflow.py (+2/-1)
To merge this branch: bzr merge lp:~barry/mailman/lp1435941
Reviewer Review Type Date Requested Status
Mailman Coders Pending
Review via email: mp+257022@code.launchpad.net

Description of the change

Try to make the test suite run under PostgreSQL

To post a comment you must log in.

Unmerged revisions

7336. By Barry Warsaw

Add column ids, although this causes other problems.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/mailman/database/alembic/versions/2bb9b382198_workflow_state_table.py'
--- src/mailman/database/alembic/versions/2bb9b382198_workflow_state_table.py 2015-03-29 21:14:09 +0000
+++ src/mailman/database/alembic/versions/2bb9b382198_workflow_state_table.py 2015-04-22 01:54:07 +0000
@@ -15,7 +15,9 @@
1515
1616
17def upgrade():17def upgrade():
18 op.create_table('workflowstate',18 op.create_table(
19 'workflowstate',
20 sa.Column('id', sa.Integer(), nullable=False),
19 sa.Column('name', sa.Unicode(), nullable=False),21 sa.Column('name', sa.Unicode(), nullable=False),
20 sa.Column('key', sa.Unicode(), nullable=False),22 sa.Column('key', sa.Unicode(), nullable=False),
21 sa.Column('step', sa.Unicode(), nullable=True),23 sa.Column('step', sa.Unicode(), nullable=True),
2224
=== modified file 'src/mailman/database/alembic/versions/46e92facee7_add_serverowner_domainowner.py'
--- src/mailman/database/alembic/versions/46e92facee7_add_serverowner_domainowner.py 2015-04-06 23:07:42 +0000
+++ src/mailman/database/alembic/versions/46e92facee7_add_serverowner_domainowner.py 2015-04-22 01:54:07 +0000
@@ -34,6 +34,7 @@
34def upgrade():34def upgrade():
35 op.create_table(35 op.create_table(
36 'domain_owner',36 'domain_owner',
37 sa.Column('id', sa.Integer(), nullable=False),
37 sa.Column('user_id', sa.Integer(), nullable=False),38 sa.Column('user_id', sa.Integer(), nullable=False),
38 sa.Column('domain_id', sa.Integer(), nullable=False),39 sa.Column('domain_id', sa.Integer(), nullable=False),
39 sa.ForeignKeyConstraint(['domain_id'], ['domain.id'], ),40 sa.ForeignKeyConstraint(['domain_id'], ['domain.id'], ),
4041
=== modified file 'src/mailman/docs/RELEASENOTES.rst'
--- src/mailman/docs/RELEASENOTES.rst 2015-04-18 01:35:01 +0000
+++ src/mailman/docs/RELEASENOTES.rst 2015-04-22 01:54:07 +0000
@@ -21,3 +21,7 @@
21The documentation here describes the Mailman Core in great detail.21The documentation here describes the Mailman Core in great detail.
22Postorius, Hyperkitty, mailman.client, and the bundler are described and22Postorius, Hyperkitty, mailman.client, and the bundler are described and
23developed elsewhere.23developed elsewhere.
24
25More release notes are maintained on the `Mailman wiki`_.
26
27.. _`Mailman wiki`: http://wiki.list.org/Mailman3
2428
=== modified file 'src/mailman/model/user.py'
--- src/mailman/model/user.py 2015-04-06 23:07:42 +0000
+++ src/mailman/model/user.py 2015-04-22 01:54:07 +0000
@@ -186,5 +186,6 @@
186186
187 __tablename__ = 'domain_owner'187 __tablename__ = 'domain_owner'
188188
189 id = Column(Integer, primary_key=True)
189 user_id = Column(Integer, ForeignKey('user.id'), primary_key=True)190 user_id = Column(Integer, ForeignKey('user.id'), primary_key=True)
190 domain_id = Column(Integer, ForeignKey('domain.id'), primary_key=True)191 domain_id = Column(Integer, ForeignKey('domain.id'), primary_key=True)
191192
=== modified file 'src/mailman/model/workflow.py'
--- src/mailman/model/workflow.py 2015-04-14 22:54:05 +0000
+++ src/mailman/model/workflow.py 2015-04-22 01:54:07 +0000
@@ -26,7 +26,7 @@
26from mailman.database.model import Model26from mailman.database.model import Model
27from mailman.database.transaction import dbconnection27from mailman.database.transaction import dbconnection
28from mailman.interfaces.workflow import IWorkflowState, IWorkflowStateManager28from mailman.interfaces.workflow import IWorkflowState, IWorkflowStateManager
29from sqlalchemy import Column, Unicode29from sqlalchemy import Column, Integer, Unicode
30from zope.interface import implementer30from zope.interface import implementer
3131
3232
@@ -37,6 +37,7 @@
3737
38 __tablename__ = 'workflowstate'38 __tablename__ = 'workflowstate'
3939
40 id = Column(Integer, primary_key=True)
40 name = Column(Unicode, primary_key=True)41 name = Column(Unicode, primary_key=True)
41 token = Column(Unicode, primary_key=True)42 token = Column(Unicode, primary_key=True)
42 step = Column(Unicode)43 step = Column(Unicode)