Merge lp:~azzar1/unity/fix-1048274-6.0 into lp:unity/6.0

Proposed by Andrea Azzarone
Status: Merged
Approved by: Brandon Schaefer
Approved revision: no longer in the source branch.
Merged at revision: 2782
Proposed branch: lp:~azzar1/unity/fix-1048274-6.0
Merge into: lp:unity/6.0
Diff against target: 27 lines (+1/-3)
2 files modified
launcher/HudLauncherIcon.cpp (+0/-2)
launcher/HudLauncherIcon.h (+1/-1)
To merge this branch: bzr merge lp:~azzar1/unity/fix-1048274-6.0
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
Review via email: mp+129370@code.launchpad.net

Commit message

Make HudLauncherIcon::ubus_manager_ "un-static" (LP bug 1048274)

Description of the change

== Problem ==
compiz crashed with SIGSEGV in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string() from unity::launcher::HudLauncherIcon::OnHudIconChanged()

== Fix ==
HudLauncherIcon::ubus_manager_ should not be static.

== Test ==
Not applicable.

To post a comment you must log in.
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Still Looks good :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'launcher/HudLauncherIcon.cpp'
--- launcher/HudLauncherIcon.cpp 2012-09-07 15:03:13 +0000
+++ launcher/HudLauncherIcon.cpp 2012-10-12 08:31:24 +0000
@@ -37,8 +37,6 @@
37nux::logging::Logger logger("unity.launcher.hudlaunchericon");37nux::logging::Logger logger("unity.launcher.hudlaunchericon");
38}38}
3939
40UBusManager HudLauncherIcon::ubus_manager_;
41
42HudLauncherIcon::HudLauncherIcon(LauncherHideMode hide_mode)40HudLauncherIcon::HudLauncherIcon(LauncherHideMode hide_mode)
43 : SingleMonitorLauncherIcon(IconType::HUD, 0)41 : SingleMonitorLauncherIcon(IconType::HUD, 0)
44 , launcher_hide_mode_(hide_mode)42 , launcher_hide_mode_(hide_mode)
4543
=== modified file 'launcher/HudLauncherIcon.h'
--- launcher/HudLauncherIcon.h 2012-08-22 08:17:33 +0000
+++ launcher/HudLauncherIcon.h 2012-10-12 08:31:24 +0000
@@ -49,9 +49,9 @@
49 void OnOverlayShown(GVariant *data, bool visible);49 void OnOverlayShown(GVariant *data, bool visible);
50 void OnHudIconChanged(GVariant *data);50 void OnHudIconChanged(GVariant *data);
5151
52 static unity::UBusManager ubus_manager_;
53 nux::Color background_color_;52 nux::Color background_color_;
54 LauncherHideMode launcher_hide_mode_;53 LauncherHideMode launcher_hide_mode_;
54 UBusManager ubus_manager_;
55};55};
5656
57}57}

Subscribers

People subscribed via source and target branches