Merge lp:~azzar1/unity-control-center/fix-1716359 into lp:unity-control-center

Proposed by Andrea Azzarone
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 12906
Merged at revision: 12906
Proposed branch: lp:~azzar1/unity-control-center/fix-1716359
Merge into: lp:unity-control-center
Diff against target: 23 lines (+6/-0)
1 file modified
panels/sound/gvc-mixer-dialog.c (+6/-0)
To merge this branch: bzr merge lp:~azzar1/unity-control-center/fix-1716359
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+332901@code.launchpad.net

Commit message

Use row-activated signal instead of selection-changed. This will avoid that hy u-c-c decides which port the system should use after the user unplugs the headset. PulseAudio will do the job for us.

To post a comment you must log in.
12906. By Andrea Azzarone

Use row-activated signal instead of selection-changed. This will avoid that hy u-c-c decides which port the system should use after the user unplugs the headset. PulseAudio will do the job for us.

Revision history for this message
Sebastien Bacher (seb128) wrote :

looks good, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'panels/sound/gvc-mixer-dialog.c'
--- panels/sound/gvc-mixer-dialog.c 2014-11-12 09:51:13 +0000
+++ panels/sound/gvc-mixer-dialog.c 2017-10-27 16:54:32 +0000
@@ -1509,6 +1509,9 @@
1509 gboolean active;1509 gboolean active;
1510 guint id;1510 guint id;
15111511
1512 if (gtk_get_current_event_device () == NULL)
1513 return;
1514
1512 if (gtk_tree_selection_get_selected (selection, &model, &iter) == FALSE) {1515 if (gtk_tree_selection_get_selected (selection, &model, &iter) == FALSE) {
1513 g_debug ("Could not get default input from selection");1516 g_debug ("Could not get default input from selection");
1514 return;1517 return;
@@ -1544,6 +1547,9 @@
1544 gboolean active;1547 gboolean active;
1545 guint id;1548 guint id;
15461549
1550 if (gtk_get_current_event_device () == NULL)
1551 return;
1552
1547 if (gtk_tree_selection_get_selected (selection, &model, &iter) == FALSE) {1553 if (gtk_tree_selection_get_selected (selection, &model, &iter) == FALSE) {
1548 g_debug ("Could not get default output from selection");1554 g_debug ("Could not get default output from selection");
1549 return;1555 return;

Subscribers

People subscribed via source and target branches