Merge lp:~axwalk/gwacl/retry-rewind-request-body into lp:gwacl
Proposed by
Andrew Wilkins
Status: | Merged |
---|---|
Approved by: | Andrew Wilkins |
Approved revision: | 233 |
Merged at revision: | 232 |
Proposed branch: | lp:~axwalk/gwacl/retry-rewind-request-body |
Merge into: | lp:gwacl |
Diff against target: |
80 lines (+39/-2) 2 files modified
x509dispatcher.go (+14/-2) x509dispatcher_test.go (+25/-0) |
To merge this branch: | bzr merge lp:~axwalk/gwacl/retry-rewind-request-body |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ian Booth | Approve | ||
Review via email: mp+210118@code.launchpad.net |
Commit message
Rewind body when retrying POST/PUT/etc.
Azure may tell us to retry POST/PUT, which
may have a body. We must rewind the reader
if this happens.
Description of the change
Rewind body when retrying POST/PUT/etc.
Azure may tell us to retry POST/PUT, which
may have a body. We must rewind the reader
if this happens.
To post a comment you must log in.
Looks good.
Small typo:
+// to the beginning of the reader upong Close being called.