Merge lp:~andrewsomething/gm-notify/lp-597407 into lp:gm-notify

Proposed by Andrew Starr-Bochicchio
Status: Merged
Merged at revision: 75
Proposed branch: lp:~andrewsomething/gm-notify/lp-597407
Merge into: lp:gm-notify
Diff against target: 52 lines (+5/-5)
2 files modified
gm-notify (+3/-3)
gm-notify-config (+2/-2)
To merge this branch: bzr merge lp:~andrewsomething/gm-notify/lp-597407
Reviewer Review Type Date Requested Status
Alexander Hungenberg (community) Approve
Review via email: mp+28263@code.launchpad.net

Description of the change

Hi Alexander,

Thanks for your quick response before. Unfotunetly, I just noticed that my patch was not complete. There were a few subprocess calls that needed renaming as well. This branch should finish it off.

To post a comment you must log in.
Revision history for this message
Alexander Hungenberg (alexander-hungenberg-gmail) wrote :

oh - indeed :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'gm-notify'
--- gm-notify 2010-06-22 19:46:39 +0000
+++ gm-notify 2010-06-23 04:52:29 +0000
@@ -1,7 +1,7 @@
1#!/usr/bin/env python1#!/usr/bin/env python
2# -*- coding: utf-8 -*-2# -*- coding: utf-8 -*-
33
4# gm-notify.py v0.10.24# gm-notify v0.10.2
5# a simple and lightweight GMail-Notifier for ubuntu and notify-osd5# a simple and lightweight GMail-Notifier for ubuntu and notify-osd
6#6#
7# Copyright (c) 2009-2010, Alexander Hungenberg <alexander.hungenberg@gmail.com>7# Copyright (c) 2009-2010, Alexander Hungenberg <alexander.hungenberg@gmail.com>
@@ -62,7 +62,7 @@
62 In the end it starts the periodic check timer and a gtk main-loop'''62 In the end it starts the periodic check timer and a gtk main-loop'''
63 63
64 # Kill running gm-notify processes (UGLY!)64 # Kill running gm-notify processes (UGLY!)
65 subprocess.call("kill `pgrep -f gm-notify.py | grep -v %s`" % os.getpid(), stdout=open("/dev/null", "w"), shell=True)65 subprocess.call("kill `pgrep -f gm-notify | grep -v %s`" % os.getpid(), stdout=open("/dev/null", "w"), shell=True)
66 66
67 # Initiate pynotify and Gnome Keyring67 # Initiate pynotify and Gnome Keyring
68 if not pynotify.init(_("GMail Notifier")):68 if not pynotify.init(_("GMail Notifier")):
@@ -74,7 +74,7 @@
74 else:74 else:
75 # Start gm-notify-config if no credentials are found75 # Start gm-notify-config if no credentials are found
76 try:76 try:
77 subprocess.call(get_executable_path("gm-notify-config.py"))77 subprocess.call(get_executable_path("gm-notify-config"))
78 except PathNotFound:78 except PathNotFound:
79 print(_("gm-notify-config utility was not found"))79 print(_("gm-notify-config utility was not found"))
80 sys.exit(-1)80 sys.exit(-1)
8181
=== modified file 'gm-notify-config'
--- gm-notify-config 2010-06-22 19:46:39 +0000
+++ gm-notify-config 2010-06-23 04:52:29 +0000
@@ -1,7 +1,7 @@
1#!/usr/bin/env python1#!/usr/bin/env python
2# -*- coding: utf-8 -*-2# -*- coding: utf-8 -*-
33
4# gm-notify-config.py v0.10.24# gm-notify-config v0.10.2
5# GMail Notifier Configuration Utility5# GMail Notifier Configuration Utility
6#6#
7# Copyright (c) 2009-2010, Alexander Hungenberg <alexander.hungenberg@gmail.com>7# Copyright (c) 2009-2010, Alexander Hungenberg <alexander.hungenberg@gmail.com>
@@ -172,7 +172,7 @@
172 print "Warning: cannot delete", self.autostart_file172 print "Warning: cannot delete", self.autostart_file
173173
174 # Start gm-notify itself174 # Start gm-notify itself
175 subprocess.Popen(get_executable_path("gm-notify.py"))175 subprocess.Popen(get_executable_path("gm-notify"))
176 176
177 def terminate(self, widget):177 def terminate(self, widget):
178 reactor.stop()178 reactor.stop()

Subscribers

People subscribed via source and target branches

to status/vote changes: