Merge lp:~andrewsomething/bzr-builddeb/lp876888 into lp:bzr-builddeb

Proposed by Andrew Starr-Bochicchio
Status: Merged
Approved by: James Westby
Approved revision: 639
Merged at revision: 639
Proposed branch: lp:~andrewsomething/bzr-builddeb/lp876888
Merge into: lp:bzr-builddeb
Diff against target: 48 lines (+7/-7)
2 files modified
debian/control (+2/-2)
util.py (+5/-5)
To merge this branch: bzr merge lp:~andrewsomething/bzr-builddeb/lp876888
Reviewer Review Type Date Requested Status
James Westby Approve
Review via email: mp+80698@code.launchpad.net

Description of the change

Use python-distro-info to get list of all Debain and Ubuntu releases.

I would have liked to have gotten rid of the suite_to_distribution function and just use python-distro-info directly, but it doesn't seem to understand '-proposed', '-updates', '-security', '-backports', ect.

>>> UbuntuDistroInfo().valid('natty-updates')
False
>>> UbuntuDistroInfo().valid('natty')
True

This at least makes it so new Ubuntu releases don't have to be manually added every six months.

All tests for util.py pass, but there are some seemingly unrelated failures.

To post a comment you must log in.
Revision history for this message
James Westby (james-w) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2011-07-26 13:11:08 +0000
+++ debian/control 2011-10-28 16:44:34 +0000
@@ -4,7 +4,7 @@
4Maintainer: Debian Bazaar Maintainers <pkg-bazaar-maint@lists.alioth.debian.org>4Maintainer: Debian Bazaar Maintainers <pkg-bazaar-maint@lists.alioth.debian.org>
5Uploaders: Reinhard Tartler <siretart@tauware.de>, James Westby <james.westby@ubuntu.com>, Jelmer Vernooij <jelmer@debian.org>5Uploaders: Reinhard Tartler <siretart@tauware.de>, James Westby <james.westby@ubuntu.com>, Jelmer Vernooij <jelmer@debian.org>
6Build-Depends: debhelper (>= 5.0.37.2), python-all (>= 2.6.6-3)6Build-Depends: debhelper (>= 5.0.37.2), python-all (>= 2.6.6-3)
7Build-Depends-Indep: bzr (>= 2.1~), python-docutils, python-debian (>= 0.1.11), python-apt, patchutils, python-testtools (>= 0.9.2), pristine-tar, devscripts (>= 2.10.59), python-subunit, python-bzrlib.tests | bzr (<< 2.4.0~beta1-2), python-lzma, libalgorithm-merge-perl7Build-Depends-Indep: bzr (>= 2.1~), python-docutils, python-debian (>= 0.1.11), python-apt, patchutils, python-testtools (>= 0.9.2), pristine-tar, devscripts (>= 2.10.59), python-subunit, python-bzrlib.tests | bzr (<< 2.4.0~beta1-2), python-lzma, libalgorithm-merge-perl, python-distro-info
8Vcs-Bzr: http://bzr.debian.org/pkg-bazaar/bzr-builddeb/unstable8Vcs-Bzr: http://bzr.debian.org/pkg-bazaar/bzr-builddeb/unstable
9Vcs-Browser: http://bzr.debian.org/loggerhead/pkg-bazaar/bzr-builddeb/unstable9Vcs-Browser: http://bzr.debian.org/loggerhead/pkg-bazaar/bzr-builddeb/unstable
10X-Python-Version: >= 2.410X-Python-Version: >= 2.4
@@ -12,7 +12,7 @@
1212
13Package: bzr-builddeb13Package: bzr-builddeb
14Architecture: all14Architecture: all
15Depends: bzr (>= 2.1~), python-debian (>= 0.1.11), python-apt, ${python:Depends}, dpkg-dev, fakeroot, devscripts (>= 2.10.59), patchutils, pristine-tar, ${misc:Depends}15Depends: bzr (>= 2.1~), python-debian (>= 0.1.11), python-apt, ${python:Depends}, dpkg-dev, fakeroot, devscripts (>= 2.10.59), patchutils, pristine-tar, ${misc:Depends}, python-distro-info
16Recommends: python-launchpadlib, libalgorithm-merge-perl16Recommends: python-launchpadlib, libalgorithm-merge-perl
17Suggests: bzr-svn (>= 0.4.10), python-lzma17Suggests: bzr-svn (>= 0.4.10), python-lzma
18Provides: bzr-buildpackage18Provides: bzr-buildpackage
1919
=== modified file 'util.py'
--- util.py 2011-10-11 23:41:58 +0000
+++ util.py 2011-10-28 16:44:34 +0000
@@ -29,6 +29,8 @@
29import os29import os
30import re30import re
3131
32from distro_info import DebianDistroInfo, UbuntuDistroInfo
33
32from bzrlib.trace import mutter34from bzrlib.trace import mutter
3335
34try:36try:
@@ -75,12 +77,10 @@
75 )77 )
7678
7779
78DEBIAN_RELEASES = ('woody', 'sarge', 'etch', 'lenny', 'squeeze', 'wheezy',80DEBIAN_RELEASES = DebianDistroInfo().all
79 'stable', 'testing', 'unstable', 'experimental', 'frozen', 'sid')81DEBIAN_RELEASES.extend(['stable', 'testing', 'unstable', 'frozen'])
80DEBIAN_POCKETS = ('', '-security', '-proposed-updates', '-backports')82DEBIAN_POCKETS = ('', '-security', '-proposed-updates', '-backports')
81UBUNTU_RELEASES = ('warty', 'hoary', 'breezy', 'dapper', 'edgy',83UBUNTU_RELEASES = UbuntuDistroInfo().all
82 'feisty', 'gutsy', 'hardy', 'intrepid', 'jaunty', 'karmic',
83 'lucid', 'maverick', 'natty', "oneiric")
84UBUNTU_POCKETS = ('', '-proposed', '-updates', '-security', '-backports')84UBUNTU_POCKETS = ('', '-proposed', '-updates', '-security', '-backports')
8585
8686

Subscribers

People subscribed via source and target branches