Merge lp:~andreserl/maas/refactor_debconf_selections_preseed into lp:~maas-committers/maas/trunk
Status: | Rejected |
---|---|
Rejected by: | MAAS Lander |
Proposed branch: | lp:~andreserl/maas/refactor_debconf_selections_preseed |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
229 lines (+27/-44) 6 files modified
contrib/preseeds_v2/curtin_userdata (+0/-5) contrib/preseeds_v2/curtin_userdata_centos (+0/-6) contrib/preseeds_v2/curtin_userdata_suse (+0/-6) contrib/preseeds_v2/curtin_userdata_windows (+0/-6) src/maasserver/preseed.py (+18/-10) src/maasserver/tests/test_preseed.py (+9/-11) |
To merge this branch: | bzr merge lp:~andreserl/maas/refactor_debconf_selections_preseed |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
MAAS Maintainers | Pending | ||
Review via email: mp+318702@code.launchpad.net |
Commit message
Refactor the way Cloud Init configuration (cloudconfig) for debconf selections is inserted into the curtin preseed.
Description of the change
Ubuntu requires to insert Cloud Config (in the curtin preseed) for the deployed node's cloud-init configuration. This allows cloud init in the deployed node to read user-data from the local system and perform system configuration on first boot.
This refactor injects in a better way that allows this to be expanded and support Ubuntu Core, provided that Ubuntu Core will ignore debconf_selections, but will still require 'cloudconfig'. A branch will follow adding such cloud-config.
Unmerged revisions
- 5771. By Andres Rodriguez
-
Refactor how we obtain debconf selections to not do it in the preseed. This is in preparation to supporting Ubuntu Core, as it makes it easier to add curtin config. Ubuntu Core will ignore debconf selections, but requires cloudconfig to be sent instead.
Looks good. Just one comment about compatibility.