Merge lp:~andreserl/debian-cd/maas into lp:~ubuntu-cdimage/debian-cd/ubun3

Proposed by Andres Rodriguez
Status: Merged
Merged at revision: 1935
Proposed branch: lp:~andreserl/debian-cd/maas
Merge into: lp:~ubuntu-cdimage/debian-cd/ubun3
Diff against target: 37 lines (+18/-7)
1 file modified
tools/boot/xenial/boot-amd64 (+18/-7)
To merge this branch: bzr merge lp:~andreserl/debian-cd/maas
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre (community) Approve
VCS imports Pending
Review via email: mp+291285@code.launchpad.net

This proposal supersedes a proposal from 2016-04-07.

Commit message

Add CD Options for Installing MAAS Region Controller and Rack Controller.

Description of the change

This branch adds the too options and replaces the old way of installing MAAS from the CD. This is dependent in the following branch been released in Ubuntu:
https://code.launchpad.net/~andreserl/maas/lp1561954/+merge/291259

To post a comment you must log in.
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

It looks reasonable, but why add the menu items in two passes at writing to txt.cfg or grub.cfg, if you can do it in just one?

You also can't use the 'cloud' label twice, that label will be used to start the right menu option if all you have is a command-line, so it can be useful on, for instance, powerpc.

Please fix the labels and make it all a write in one go ;)

review: Needs Fixing
lp:~andreserl/debian-cd/maas updated
1936. By Andres Rodriguez

Fix installer

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Looks great now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tools/boot/xenial/boot-amd64'
--- tools/boot/xenial/boot-amd64 2015-10-22 16:03:46 +0000
+++ tools/boot/xenial/boot-amd64 2016-04-07 21:18:09 +0000
@@ -527,15 +527,26 @@
527 # This really ought to be in gfxboot.cfg instead, but we want to527 # This really ought to be in gfxboot.cfg instead, but we want to
528 # make it particularly prominent.528 # make it particularly prominent.
529 cat >> boot$N/isolinux/txt.cfg <<EOF529 cat >> boot$N/isolinux/txt.cfg <<EOF
530label cloud530label maas
531 menu label ^Multiple server install with MAAS531 menu label ^Install MAAS Region Controller
532 kernel /install/vmlinuz532 kernel /install/vmlinuz
533 append $KERNEL_PARAMS $FRONTEND_BACKGROUND modules=maas-enlist-udeb vga=788 initrd=/install/initrd.gz quiet ---533 append $KERNEL_PARAMS $FRONTEND_BACKGROUND modules=maas-region-udeb vga=788 initrd=/install/initrd.gz quiet ---
534
535label maasrack
536 menu label ^Install MAAS Rack Controller
537 kernel /install/vmlinuz
538 append $KERNEL_PARAMS $FRONTEND_BACKGROUND modules=maas-rack-udeb vga=788 initrd=/install/initrd.gz quiet ---
534EOF539EOF
535 cat >> $CDDIR/boot/grub/grub.cfg <<EOF540 cat >> $CDDIR/boot/grub/grub.cfg <<EOF
536menuentry "Multiple server install with MAAS" {541menuentry "Install MAAS Region Controller" {
537 set gfxpayload=keep542 set gfxpayload=keep
538 linux /install/vmlinuz $KERNEL_PARAMS modules=maas-enlist-udeb vga=788 initrd=/install/initrd.gz quiet ---543 linux /install/vmlinuz $KERNEL_PARAMS modules=maas-region-udeb vga=788 initrd=/install/initrd.gz quiet ---
544 initrd /install/initrd.gz
545}
546
547menuentry "Install MAAS Rack Controller" {
548 set gfxpayload=keep
549 linux /install/vmlinuz $KERNEL_PARAMS modules=maas-rack-udeb vga=788 initrd=/install/initrd.gz quiet ---
539 initrd /install/initrd.gz550 initrd /install/initrd.gz
540}551}
541EOF552EOF

Subscribers

People subscribed via source and target branches