Merge lp:~andreas-pokorny/qtmir/fix-1557634 into lp:qtmir

Proposed by Andreas Pokorny
Status: Merged
Approved by: Daniel d'Andrada
Approved revision: 626
Merged at revision: 632
Proposed branch: lp:~andreas-pokorny/qtmir/fix-1557634
Merge into: lp:qtmir
Diff against target: 40 lines (+17/-3)
2 files modified
src/modules/Unity/Application/mirsurface.cpp (+8/-1)
src/platforms/mirserver/inputdeviceobserver.cpp (+9/-2)
To merge this branch: bzr merge lp:~andreas-pokorny/qtmir/fix-1557634
Reviewer Review Type Date Requested Status
Daniel d'Andrada (community) Approve
Unity8 CI Bot (community) continuous-integration Approve
Review via email: mp+321050@code.launchpad.net

Commit message

Report and consume exception that may occur on constructing a keymap

Description of the change

This handles construction exceptions that are thrown in mir when a keymap is configured that xkbcommon cannot find.

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:626
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-ci/637/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/4706/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4734
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4556
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4556/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4556
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4556/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4556
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4556/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4556
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4556/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4556/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4556
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4556/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-ci/637/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:626
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-ci/638/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4707
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4735
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4558
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4558/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4558
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4558/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4558
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4558/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4558
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4558/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4558
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4558/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4558
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4558/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-ci/638/rebuild

review: Approve (continuous-integration)
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/modules/Unity/Application/mirsurface.cpp'
--- src/modules/Unity/Application/mirsurface.cpp 2017-03-20 21:15:13 +0000
+++ src/modules/Unity/Application/mirsurface.cpp 2017-03-27 10:09:19 +0000
@@ -806,7 +806,14 @@
806 return;806 return;
807 }807 }
808808
809 m_surface->set_keymap(MirInputDeviceId(), "", layout.toStdString(), variant.toStdString(), "");809 try
810 {
811 m_surface->set_keymap(MirInputDeviceId(), "", layout.toStdString(), variant.toStdString(), "");
812 }
813 catch(std::exception const& e)
814 {
815 WARNING_MSG << "Setting keymap failed:" << e.what();
816 }
810}817}
811818
812QCursor MirSurface::cursor() const819QCursor MirSurface::cursor() const
813820
=== modified file 'src/platforms/mirserver/inputdeviceobserver.cpp'
--- src/platforms/mirserver/inputdeviceobserver.cpp 2017-01-26 17:50:12 +0000
+++ src/platforms/mirserver/inputdeviceobserver.cpp 2017-03-27 10:09:19 +0000
@@ -100,7 +100,14 @@
100 keymap.layout = layout.toStdString();100 keymap.layout = layout.toStdString();
101 keymap.variant = variant.toStdString();101 keymap.variant = variant.toStdString();
102102
103 device->apply_keyboard_configuration(std::move(keymap));103 try
104 qCDebug(QTMIR_MIR_KEYMAP) << "Keymap applied";104 {
105 device->apply_keyboard_configuration(std::move(keymap));
106 qCDebug(QTMIR_MIR_KEYMAP) << "Keymap applied";
107 }
108 catch(std::exception const& e)
109 {
110 qCWarning(QTMIR_MIR_KEYMAP) << "Keymap could not be applied:" << e.what();
111 }
105 }112 }
106}113}

Subscribers

People subscribed via source and target branches