Merge lp:~amigadave/account-plugins/packaging-enable-tests into lp:account-plugins

Proposed by David King
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 87
Merged at revision: 86
Proposed branch: lp:~amigadave/account-plugins/packaging-enable-tests
Merge into: lp:account-plugins
Diff against target: 41 lines (+11/-4)
2 files modified
debian/changelog (+8/-2)
debian/control (+3/-2)
To merge this branch: bzr merge lp:~amigadave/account-plugins/packaging-enable-tests
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+138961@code.launchpad.net

Commit message

Build-depend on libxml2-utils for xmllint

This enables the XML well-formed tests at configure time, and additionally updates the VCS and homepage location.

Description of the change

Build-depend on libxml2-utils for xmllint

This enables the XML well-formed tests at configure time, and additionally updates the VCS and homepage location.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Looks nice!

Just a quick note, can you please add a finale , after the new build-dep? This avoid noise in diff for further addition/removal and we try to keep the same syntax for every packages around here. :)

Revision history for this message
David King (amigadave) wrote :

A relevant bit from the build log:

PASS: test-provider
PASS: test-service
==================
All 2 tests passed
==================

87. By David King

Add a trailing comma to the build-depends list

Revision history for this message
David King (amigadave) wrote :

Done, and thanks for the suggestion.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Approving then :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2012-11-30 16:12:35 +0000
+++ debian/changelog 2012-12-10 13:49:22 +0000
@@ -1,10 +1,16 @@
1account-plugins (0.10bzr12.11.30-0ubuntu2) UNRELEASED; urgency=low1account-plugins (0.10bzr12.11.30-0ubuntu3) UNRELEASED; urgency=low
22
3 [ Ken VanDine ]
3 * debian/control4 * debian/control
4 - account-plugin-tools should depend on gir1.2-signon-1.0 and5 - account-plugin-tools should depend on gir1.2-signon-1.0 and
5 gir1.2-accounts-1.06 gir1.2-accounts-1.0
67
7 -- Ken VanDine <ken.vandine@canonical.com> Fri, 30 Nov 2012 11:11:43 -05008 [ David King ]
9 * debian/control
10 - Build-depend on libxml2-utils for XML well-formedness tests
11 - Update homepage and VCS location
12
13 -- David King <david.king@canonical.com> Mon, 10 Dec 2012 12:45:48 +0000
814
9account-plugins (0.10bzr12.11.30-0ubuntu1) raring; urgency=low15account-plugins (0.10bzr12.11.30-0ubuntu1) raring; urgency=low
1016
1117
=== modified file 'debian/control'
--- debian/control 2012-11-30 16:12:35 +0000
+++ debian/control 2012-12-10 13:49:22 +0000
@@ -13,11 +13,12 @@
13 valac-0.16,13 valac-0.16,
14 gnome-common,14 gnome-common,
15 dh-autoreconf,15 dh-autoreconf,
16 libxml2-utils,
16Standards-Version: 3.9.317Standards-Version: 3.9.3
17Homepage: https://launchpad.net/online-accounts-account-plugins18Homepage: https://launchpad.net/account-plugins
18# If you aren't a member of ~online-accounts but need to upload packaging changes,19# If you aren't a member of ~online-accounts but need to upload packaging changes,
19# just go ahead. ~online-accounts will notice and sync up the code again.20# just go ahead. ~online-accounts will notice and sync up the code again.
20Vcs-Bzr: https://code.launchpad.net/~online-accounts/online-accounts-account-plugins/trunk21Vcs-Bzr: https://code.launchpad.net/~online-accounts/account-plugins/trunk
2122
22Package: account-plugin-google23Package: account-plugin-google
23Architecture: any24Architecture: any

Subscribers

People subscribed via source and target branches