Merge lp:~allenap/maas/packaging.normalise-logging--bug-1639182--yakkety--2.1 into lp:~maas-maintainers/maas/packaging-2.1

Proposed by Gavin Panella
Status: Merged
Approved by: Gavin Panella
Approved revision: 538
Merged at revision: 538
Proposed branch: lp:~allenap/maas/packaging.normalise-logging--bug-1639182--yakkety--2.1
Merge into: lp:~maas-maintainers/maas/packaging-2.1
Diff against target: 35 lines (+7/-4)
2 files modified
debian/maas-rack-controller.maas-rackd.service (+3/-2)
debian/maas-region-api.maas-regiond-worker@.service (+4/-2)
To merge this branch: bzr merge lp:~allenap/maas/packaging.normalise-logging--bug-1639182--yakkety--2.1
Reviewer Review Type Date Requested Status
Gavin Panella (community) Approve
Review via email: mp+312041@code.launchpad.net

Commit message

Backport r536 from trunk: Use a custom logger when invoking twistd3.

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

Voting does not meet specified criteria. Required: Approve >= 1, Disapprove == 0. Got: 1 Pending.

Revision history for this message
Gavin Panella (allenap) wrote :

Backport so self-reviewing.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/maas-rack-controller.maas-rackd.service'
--- debian/maas-rack-controller.maas-rackd.service 2016-03-31 21:53:56 +0000
+++ debian/maas-rack-controller.maas-rackd.service 2016-11-29 12:44:22 +0000
@@ -18,10 +18,11 @@
18# Logs go to the journal; read them with18# Logs go to the journal; read them with
19# journalctl -u maas-rackd19# journalctl -u maas-rackd
20# Logs also go to $LOGFILE for backward compatibility. The journal20# Logs also go to $LOGFILE for backward compatibility. The journal
21# should now be preferred as the $LOGFILE will be removed in MAAS 1.9.21# should now be preferred as the $LOGFILE will be removed.
22ExecStart=/bin/sh -c \22ExecStart=/bin/sh -c \
23 'exec /usr/bin/authbind --deep /usr/bin/twistd3 --nodaemon --pidfile= \23 'exec /usr/bin/authbind --deep /usr/bin/twistd3 --nodaemon --pidfile= \
24 maas-rackd 2>&1 | tee -a $LOGFILE'24 --logger=provisioningserver.logger.EventLogger maas-rackd 2>&1 | \
25 tee -a $LOGFILE'
2526
26[Install]27[Install]
27WantedBy=multi-user.target28WantedBy=multi-user.target
2829
=== modified file 'debian/maas-region-api.maas-regiond-worker@.service'
--- debian/maas-region-api.maas-regiond-worker@.service 2016-03-31 21:53:56 +0000
+++ debian/maas-region-api.maas-regiond-worker@.service 2016-11-29 12:44:22 +0000
@@ -19,9 +19,11 @@
19# Logs go to the journal; read them with:19# Logs go to the journal; read them with:
20# journalctl -u maas-regiond-worker@*20# journalctl -u maas-regiond-worker@*
21# Logs also go to $LOGFILE for backward compatibility. The journal21# Logs also go to $LOGFILE for backward compatibility. The journal
22# should now be preferred as $LOGFILE will be removed in MAAS 1.9.22# should now be preferred as $LOGFILE will be removed.
23ExecStart=/bin/sh -c \23ExecStart=/bin/sh -c \
24 'exec twistd3 --nodaemon --pidfile= maas-regiond 2>&1 | tee -a $LOGFILE'24 'exec twistd3 --nodaemon --pidfile= \
25 --logger=provisioningserver.logger.EventLogger maas-regiond 2>&1 | \
26 tee -a $LOGFILE'
2527
26[Install]28[Install]
27WantedBy=maas-regiond.service29WantedBy=maas-regiond.service

Subscribers

People subscribed via source and target branches