Merge lp:~allanlesage/indicator-messages/TDD into lp:indicator-messages/0.3
Proposed by
Product Strategy Coverity Bug Uploader
Status: | Merged |
---|---|
Approved by: | Charles Kerr |
Approved revision: | 260 |
Merged at revision: | 271 |
Proposed branch: | lp:~allanlesage/indicator-messages/TDD |
Merge into: | lp:indicator-messages/0.3 |
Diff against target: |
87 lines (+23/-15) 2 files modified
Makefile.am.coverage (+8/-4) configure.ac (+15/-11) |
To merge this branch: | bzr merge lp:~allanlesage/indicator-messages/TDD |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Charles Kerr (community) | Approve | ||
Review via email: mp+102159@code.launchpad.net |
Description of the change
Changes revised under Charles' direction; Charles I've one diff beyond yours, removing an obsolete configuration, would you verify that this is correct please?
To post a comment you must log in.
Allan, I don't usually worry about indentation but the indentation in this patch is actively confusing... it looks like a "fi" is missing but isn't. Could you line up the if..elif..fi statements with each other?