Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager:add-all-rules into ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:vivid/master

Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Simon Fels
Approved revision: 2fb814980f3f79a555c1cd9f85d129ce302b60cc
Merged at revision: 1cb5b61da0075028f109ea4f168f51fade1db27b
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager:add-all-rules
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:vivid/master
Diff against target: 54 lines (+14/-7)
3 files modified
bin/modemmanager (+3/-6)
conf/77-mm-usb-device-blacklist.rules (+10/-0)
snapcraft.yaml (+1/-1)
Reviewer Review Type Date Requested Status
Tony Espy Approve
Matteo Croce (community) Approve
Review via email: mp+304892@code.launchpad.net

Commit message

Ignore BLIP camera by using udev rules (LP: #1615853)

Description of the change

Ignore BLIP camera by using udev rules (LP: #1615853)

To post a comment you must log in.
Revision history for this message
Matteo Croce (teknoraver) :
review: Approve
Revision history for this message
Tony Espy (awe) wrote :

Looks good to me!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/bin/modemmanager b/bin/modemmanager
index e6de1de..3aa78c3 100755
--- a/bin/modemmanager
+++ b/bin/modemmanager
@@ -7,10 +7,8 @@ set -x
7cp $SNAP_APP_PATH/etc/dbus-1/system.d/org.freedesktop.ModemManager1.conf \7cp $SNAP_APP_PATH/etc/dbus-1/system.d/org.freedesktop.ModemManager1.conf \
8 /etc/dbus-1/system.d/$SNAP_APP.conf8 /etc/dbus-1/system.d/$SNAP_APP.conf
99
10# We need a specific udev rule in place in order to tag all10# Copy around mm udev rules
11# devices we might be interested in with a property so we11cp $SNAP_APP_PATH/conf/*.rules /etc/udev/rules.d/
12# can iterate them on startup.
13cp $SNAP_APP_PATH/conf/80-mm-candidate.rules /etc/udev/rules.d/
14# Reload all device information so that our new rule gets applied12# Reload all device information so that our new rule gets applied
15udevadm trigger13udevadm trigger
1614
@@ -33,6 +31,5 @@ $SNAP_APP_PATH/usr/sbin/ModemManager \
33 "$@"31 "$@"
3432
35# Cleanup everything we copied into the system33# Cleanup everything we copied into the system
36rm /etc/udev/rules.d/80-mm-candidate.rules \34rm /etc/udev/rules.d/*-mm-*rules
37 /etc/udev/rules.d/77-mm-telit.rules
38udevadm trigger35udevadm trigger
diff --git a/conf/77-mm-usb-device-blacklist.rules b/conf/77-mm-usb-device-blacklist.rules
39new file mode 10064436new file mode 100644
index 0000000..9cfc805
--- /dev/null
+++ b/conf/77-mm-usb-device-blacklist.rules
@@ -0,0 +1,10 @@
1# do not edit this file, it will be overwritten on update
2
3ACTION!="add|change|move", GOTO="mm_usb_device_blacklist_end"
4SUBSYSTEM!="usb", GOTO="mm_usb_device_blacklist_end"
5ENV{DEVTYPE}!="usb_device", GOTO="mm_usb_device_blacklist_end"
6
7# Analog Devices BLIP camera
8ATTRS{idVendor}=="064b", ATTRS{idProduct}=="7823", ENV{ID_MM_DEVICE_IGNORE}="1"
9
10LABEL="mm_usb_device_blacklist_end"
diff --git a/snapcraft.yaml b/snapcraft.yaml
index f5b8d5c..f023777 100644
--- a/snapcraft.yaml
+++ b/snapcraft.yaml
@@ -73,7 +73,7 @@ parts:
73 bin/dnsmasq: bin/dnsmasq73 bin/dnsmasq: bin/dnsmasq
74 conf/NetworkManager.conf: etc/NetworkManager/NetworkManager.conf74 conf/NetworkManager.conf: etc/NetworkManager/NetworkManager.conf
75 conf/dnsmasq-dbus.conf: conf/dnsmasq-dbus.conf75 conf/dnsmasq-dbus.conf: conf/dnsmasq-dbus.conf
76 conf/80-mm-candidate.rules: conf/80-mm-candidate.rules76 conf/*.rules: conf/
7777
78 networkmanager:78 networkmanager:
79 plugin: x-custom79 plugin: x-custom

Subscribers

People subscribed via source and target branches