Merge lp:~alexhenrie24/gdebi/fix-mime-type into lp:gdebi

[Alex Henrie]

xdg-open, used by Chromium and other applications, currently opens .deb files with /usr/lib/mime/debian-view instead of GDebi. It ignores GDebi because .deb files are detected as application/vnd.debian.binary-package, but gdebi.desktop only registers the nonstandard MIME types application/x-deb and application/x-debian-package. This is unfortunate because GDebi is far more user-friendly than debian-view.

I can't see a good reason to maintain support for the nonstandard MIME types. I think it would be best to drop them and instead register the MIME type that actually works.

[Michael Vogt (mvo)]

Thanks a bunch! Its fine to remove the old mime-type, we might consider bringing it back if there are apps (like filemanagers) out there that use it to send it to gdebi. But for now I'm in favour of using only the real one. Thanks again!

review: Approve

[Alex Henrie (alexhenrie24)]

Thank you!

=== modified file 'GDebi/GDebiCommon.py'
--- GDebi/GDebiCommon.py	2014-04-22 07:44:07 +0000
+++ GDebi/GDebiCommon.py	2015-06-30 06:36:33 +0000
@@ -96,7 +96,7 @@
             logging.debug("open failed with %s" % e)
             mimetype=guess_type(file)
             if (mimetype[0] != None and
-                mimetype[0] != "application/x-debian-package"):
+                mimetype[0] != "application/vnd.debian.binary-package"):
                 self.error_header = _("'%s' is not a Debian package") % os.path.basename(file)
                 self.error_body = _("The MIME type of this file is '%s' "
                              "and can not be installed on this system.") % mimetype[0]
 
=== modified file 'data/gdebi-kde.desktop.in'
--- data/gdebi-kde.desktop.in	2013-08-03 23:06:56 +0000
+++ data/gdebi-kde.desktop.in	2015-06-30 06:36:33 +0000
@@ -7,7 +7,7 @@
 Terminal=false
 Type=Application
 Categories=Qt;KDE;System;
-MimeType=application/x-deb;application/x-debian-package;
+MimeType=application/vnd.debian.binary-package;
 OnlyShowIn=KDE;
 InitialPreference=12
 X-Ubuntu-Gettext-Domain=gdebi
 
=== modified file 'data/gdebi.desktop.in'
--- data/gdebi.desktop.in	2013-08-03 23:06:56 +0000
+++ data/gdebi.desktop.in	2015-06-30 06:36:33 +0000
@@ -7,7 +7,7 @@
 Terminal=false
 Type=Application
 Categories=System;
-MimeType=application/x-deb;application/x-debian-package;
+MimeType=application/vnd.debian.binary-package;
 NotShowIn=KDE;
 X-Ubuntu-Gettext-Domain=gdebi
 StartupNotify=true
 
=== modified file 'debian/changelog'
--- debian/changelog	2014-11-18 11:45:04 +0000
+++ debian/changelog	2015-06-30 06:36:33 +0000
@@ -2,6 +2,10 @@
 
   * Use vte 2.91
 
+  [ Alex Henrie ]
+  * Use standard MIME type vnd.debian.binary-package so that xdg-open
+    foo.deb will use gdebi
+
  -- Iain Lane <[e-mail]>  Tue, 18 Nov 2014 10:54:30 +0000
 
 gdebi (0.9.5.5) unstable; urgency=medium