Merge lp:~alan-griffiths/miral/slightly-less-broken-touch-handling into lp:miral

Proposed by Alan Griffiths
Status: Merged
Approved by: Gerry Boland
Approved revision: 181
Merged at revision: 182
Proposed branch: lp:~alan-griffiths/miral/slightly-less-broken-touch-handling
Merge into: lp:miral
Diff against target: 49 lines (+12/-2)
2 files modified
miral-shell/canonical_window_manager.cpp (+6/-1)
miral-shell/tiling_window_manager.cpp (+6/-1)
To merge this branch: bzr merge lp:~alan-griffiths/miral/slightly-less-broken-touch-handling
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
Review via email: mp+296325@code.launchpad.net

Commit message

Touch events can set active window, don't "eat" two finger gestures

Description of the change

Touch events can set active window, don't "eat" two finger gestures

Using "four fingers" for resize isn't ideal, but eating two finger gestures is just wrong.

To post a comment you must log in.
181. By Alan Griffiths

Also applies to TilingWindowManagerPolicy

Revision history for this message
Gerry Boland (gerboland) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'miral-shell/canonical_window_manager.cpp'
--- miral-shell/canonical_window_manager.cpp 2016-06-01 13:33:11 +0000
+++ miral-shell/canonical_window_manager.cpp 2016-06-02 13:24:22 +0000
@@ -621,7 +621,7 @@
621 {621 {
622 switch (count)622 switch (count)
623 {623 {
624 case 2:624 case 4:
625 resize(cursor);625 resize(cursor);
626 consumes_event = true;626 consumes_event = true;
627 break;627 break;
@@ -632,6 +632,11 @@
632 break;632 break;
633 }633 }
634 }634 }
635 else
636 {
637 if (auto const& window = tools->window_at(cursor))
638 tools->select_active_window(window);
639 }
635640
636 old_cursor = cursor;641 old_cursor = cursor;
637 return consumes_event;642 return consumes_event;
638643
=== modified file 'miral-shell/tiling_window_manager.cpp'
--- miral-shell/tiling_window_manager.cpp 2016-06-01 13:41:49 +0000
+++ miral-shell/tiling_window_manager.cpp 2016-06-02 13:24:22 +0000
@@ -366,7 +366,7 @@
366 {366 {
367 switch (count)367 switch (count)
368 {368 {
369 case 2:369 case 4:
370 resize(cursor);370 resize(cursor);
371 consumes_event = true;371 consumes_event = true;
372 break;372 break;
@@ -377,6 +377,11 @@
377 break;377 break;
378 }378 }
379 }379 }
380 else
381 {
382 if (auto const& window = tools->window_at(cursor))
383 tools->select_active_window(window);
384 }
380385
381 old_cursor = cursor;386 old_cursor = cursor;
382 return consumes_event;387 return consumes_event;

Subscribers

People subscribed via source and target branches