Merge lp:~alan-griffiths/miral/persistant-surface-store into lp:miral
Proposed by
Alan Griffiths
Status: | Rejected |
---|---|
Rejected by: | Alan Griffiths |
Proposed branch: | lp:~alan-griffiths/miral/persistant-surface-store |
Merge into: | lp:miral |
Diff against target: |
329 lines (+281/-0) 6 files modified
include/miral/toolkit/persistent_id.h (+46/-0) miral/CMakeLists.txt (+2/-0) miral/persistent_surface_store.cpp (+53/-0) miral/persistent_surface_store.h (+71/-0) test/CMakeLists.txt (+1/-0) test/persistent_surface_store.cpp (+108/-0) |
To merge this branch: | bzr merge lp:~alan-griffiths/miral/persistant-surface-store |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Chris Halse Rogers | Disapprove | ||
Alan Griffiths | Needs Information | ||
Review via email: mp+302408@code.launchpad.net |
Description of the change
I'm not sure how best to expose this functionality. I suspect that servers will only ever want to retrieve the Window/WindowInfo corresponding to a persistent ID.
If that's the case, then adding WindowManagerTo
Thoughts/
To post a comment you must log in.
Unmerged revisions
- 276. By Alan Griffiths
-
Fix for lp:1611337 has landed
- 275. By Alan Griffiths
-
Cleanup CMakeLists.txt
- 274. By Alan Griffiths
-
Split implementation code out of test
- 273. By Alan Griffiths
-
merge lp:miral
- 272. By Alan Griffiths
-
Simpler workaround
- 271. By Alan Griffiths
-
Workaround lp:1611337
- 270. By Alan Griffiths
-
merge :push
- 269. By Alan Griffiths
-
Tidy code
- 268. By Alan Griffiths
-
Split out miral/toolkit/
persistent_ id.h - 267. By Alan Griffiths
-
PersistentSurfa
ceStore. server_ can_identify_ surface_ specified_ by_client
*Discussion requested*