Merge lp:~alan-griffiths/miral/WindowControllerInterface-isVisible into lp:miral
Proposed by
Alan Griffiths
Status: | Rejected |
---|---|
Rejected by: | Alan Griffiths |
Proposed branch: | lp:~alan-griffiths/miral/WindowControllerInterface-isVisible |
Merge into: | lp:miral |
Diff against target: |
160 lines (+40/-8) 8 files modified
miral-qt/src/common/windowcontrollerinterface.h (+2/-0) miral-qt/src/modules/Unity/Application/mirsurface.cpp (+18/-5) miral-qt/src/platforms/mirserver/windowcontroller.cpp (+5/-0) miral-qt/src/platforms/mirserver/windowcontroller.h (+2/-0) miral-qt/src/platforms/mirserver/windowmanagementpolicy.cpp (+5/-0) miral-qt/src/platforms/mirserver/windowmanagementpolicy.h (+1/-0) miral-qt/tests/framework/stub_windowcontroller.h (+1/-0) miral-qt/tests/modules/WindowManager/windowmodel_test.cpp (+6/-3) |
To merge this branch: | bzr merge lp:~alan-griffiths/miral/WindowControllerInterface-isVisible |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gerry Boland (community) | Disapprove | ||
Review via email: mp+310039@code.launchpad.net |
Commit message
[miral-qt] Implement WindowControlle
To post a comment you must log in.
Unmerged revisions
- 441. By Alan Griffiths
-
Use StubWindowModel
Controller in tests where nullptr won't do - 440. By Alan Griffiths
-
Don't use the standard library when Qt has an alternative
- 439. By Alan Griffiths
-
Put const in the Qt place
- 438. By Alan Griffiths
-
Nasty hack because of existing nasty hack
- 437. By Alan Griffiths
-
Another null check
- 436. By Alan Griffiths
-
Implement WindowControlle
rInterface: :isVisible( const miral::Window &window)
""" m_surface. unique( ));
+ assert(
"""
We use Q_ASSERT() in Qt code.