Mir

Merge lp:~alan-griffiths/mir/workaround-lp1602199 into lp:mir

Proposed by Alan Griffiths
Status: Rejected
Rejected by: Alan Griffiths
Proposed branch: lp:~alan-griffiths/mir/workaround-lp1602199
Merge into: lp:mir
Diff against target: 25 lines (+4/-2)
1 file modified
tests/integration-tests/process/test_process.cpp (+4/-2)
To merge this branch: bzr merge lp:~alan-griffiths/mir/workaround-lp1602199
Reviewer Review Type Date Requested Status
Alan Griffiths Disapprove
Mir CI Bot continuous-integration Needs Fixing
Daniel van Vugt Needs Information
Review via email: mp+299831@code.launchpad.net

Commit message

Disable tests that fail in lp:1602199

Description of the change

Disable tests that fail in lp:1602199

These test Process infrastructure that supports numerous other tests. We don't rely directly on what they test for production code. And it clearly works when used in other tests.

So, if this works, we can at least unblock CI.

To post a comment you must log in.
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Continuous integration, rev:3508
https://mir-jenkins.ubuntu.com/job/mir-ci/1271/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/1489/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/1542
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1533
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/1533
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/1533
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/1504/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/1504/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/1504/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/1504
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/1504/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/1504/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/1271/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

In (duplicate?) bug 1573293 RAOF suggested NBS RPC code was to blame...?

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Is either bug a duplicate?

review: Needs Information
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> In (duplicate?) bug 1573293 RAOF suggested NBS RPC code was to blame...?

Ack

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

It seems we have more leaks in integration tests causing failures even with this workaround. But I'll land this now and assume they're unrelated...

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

On second thoughts, fixing those remaining leaks might also fix this bug. So that needs investigation.

Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Continuous integration, rev:3508
https://mir-jenkins.ubuntu.com/job/mir-ci/1280/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/1498/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/1551
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1542
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/1542
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/1542
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/1513/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/1513/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/1513/console
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/1513/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/1513/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/1513/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/1280/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

This doesn't help

review: Disapprove

Unmerged revisions

3508. By Alan Griffiths

Disable tests that fail in lp:1602199

3507. By Alan Griffiths

merge lp:~alan-griffiths/mir/BufferStreamArrangement.can_be_specified_when_creating_surface

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/integration-tests/process/test_process.cpp'
--- tests/integration-tests/process/test_process.cpp 2013-01-11 23:47:40 +0000
+++ tests/integration-tests/process/test_process.cpp 2016-07-12 15:47:43 +0000
@@ -103,8 +103,9 @@
103 EXPECT_TRUE(r.succeeded());103 EXPECT_TRUE(r.succeeded());
104}104}
105105
106// TODO: Reenable. (Disabled to workaround lp:1602199)
106TEST(Process,107TEST(Process,
107 a_main_fn_is_executed)108 DISABLED_a_main_fn_is_executed)
108{109{
109 int value = 0;110 int value = 0;
110111
@@ -118,8 +119,9 @@
118 EXPECT_TRUE(p->wait_for_termination().succeeded());119 EXPECT_TRUE(p->wait_for_termination().succeeded());
119}120}
120121
122// TODO: Reenable. (Disabled to workaround lp:1602199)
121TEST(Process,123TEST(Process,
122 a_successful_exit_function_succeeds)124 DISABLED_a_successful_exit_function_succeeds)
123{125{
124 auto p = mtf::fork_and_run_in_a_different_process(126 auto p = mtf::fork_and_run_in_a_different_process(
125 MainFunctionFactory::an_empty_main_function,127 MainFunctionFactory::an_empty_main_function,

Subscribers

People subscribed via source and target branches