Mir

Merge lp:~alan-griffiths/mir/fix-FTBFS-on-artful-clang into lp:mir

Proposed by Alan Griffiths
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 4252
Proposed branch: lp:~alan-griffiths/mir/fix-FTBFS-on-artful-clang
Merge into: lp:mir
Diff against target: 46 lines (+16/-16)
1 file modified
src/miral/set_window_management_policy.cpp (+16/-16)
To merge this branch: bzr merge lp:~alan-griffiths/mir/fix-FTBFS-on-artful-clang
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
Mir CI Bot continuous-integration Needs Fixing
Review via email: mp+330735@code.launchpad.net

Commit message

Workaround for clang crashing on artful

To post a comment you must log in.
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Continuous integration, rev:4251
https://mir-jenkins.ubuntu.com/job/mir-ci/3660/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/5009/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/5237
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=artful/5225
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/5225
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/5225
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=artful/5048
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=artful/5048/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/5048/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/5048
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/5048/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/5048
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/5048/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/5048/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=artful/5048
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=artful/5048/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=zesty/5048
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=zesty/5048/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/5048
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/5048/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/3660/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

Weird, but ok

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/miral/set_window_management_policy.cpp'
--- src/miral/set_window_management_policy.cpp 2017-08-21 14:18:55 +0000
+++ src/miral/set_window_management_policy.cpp 2017-09-14 10:35:39 +0000
@@ -32,22 +32,6 @@
32char const* const trace_option = "window-management-trace";32char const* const trace_option = "window-management-trace";
33}33}
3434
35MIRAL_FAKE_OLD_SYMBOL(
36 _ZN5miral24SetWindowManagmentPolicyC1ERKSt8functionIFSt10unique_ptrINS_22WindowManagementPolicyESt14default_deleteIS3_EERKNS_18WindowManagerToolsEEE,
37 _ZN5miral25SetWindowManagementPolicyC1ERKSt8functionIFSt10unique_ptrINS_22WindowManagementPolicyESt14default_deleteIS3_EERKNS_18WindowManagerToolsEEE)
38
39MIRAL_FAKE_OLD_SYMBOL(
40 _ZNK5miral24SetWindowManagmentPolicyclERN3mir6ServerE,
41 _ZNK5miral25SetWindowManagementPolicyclERN3mir6ServerE)
42
43MIRAL_FAKE_OLD_SYMBOL(
44 _ZN5miral24SetWindowManagmentPolicyD1Ev,
45 _ZN5miral25SetWindowManagementPolicyD1Ev)
46
47MIRAL_FAKE_OLD_SYMBOL(
48 _ZN5miral24SetWindowManagmentPolicyD2Ev,
49 _ZN5miral25SetWindowManagementPolicyD2Ev)
50
51miral::SetWindowManagementPolicy::SetWindowManagementPolicy(WindowManagementPolicyBuilder const& builder) :35miral::SetWindowManagementPolicy::SetWindowManagementPolicy(WindowManagementPolicyBuilder const& builder) :
52 builder{builder}36 builder{builder}
53{37{
@@ -89,3 +73,19 @@
89 builder);73 builder);
90 });74 });
91}75}
76
77MIRAL_FAKE_OLD_SYMBOL(
78 _ZN5miral24SetWindowManagmentPolicyC1ERKSt8functionIFSt10unique_ptrINS_22WindowManagementPolicyESt14default_deleteIS3_EERKNS_18WindowManagerToolsEEE,
79 _ZN5miral25SetWindowManagementPolicyC1ERKSt8functionIFSt10unique_ptrINS_22WindowManagementPolicyESt14default_deleteIS3_EERKNS_18WindowManagerToolsEEE)
80
81MIRAL_FAKE_OLD_SYMBOL(
82 _ZNK5miral24SetWindowManagmentPolicyclERN3mir6ServerE,
83 _ZNK5miral25SetWindowManagementPolicyclERN3mir6ServerE)
84
85MIRAL_FAKE_OLD_SYMBOL(
86 _ZN5miral24SetWindowManagmentPolicyD1Ev,
87 _ZN5miral25SetWindowManagementPolicyD1Ev)
88
89MIRAL_FAKE_OLD_SYMBOL(
90 _ZN5miral24SetWindowManagmentPolicyD2Ev,
91 _ZN5miral25SetWindowManagementPolicyD2Ev)

Subscribers

People subscribed via source and target branches