Merge lp:~al-maisan/launchpad/psds-model-changes-399186 into lp:launchpad/db-devel

[Muharem Hrnjadovic]

[Muharem Hrnjadovic (al-maisan)]

Hello there!

The branch at hand introduces the association between package sets and
distro series as well as a new model class (PackagesetGroup) that
facilitates the tracking of equivalent package sets across distro series
boundaries.

For more detail on these changes and why they are needed, please see:

  * the original "package set and distro series" meeting minutes:
    http://pastebin.ubuntu.com/302054/
  * Julian's update: http://pastebin.ubuntu.com/302058/

Please note that the underlying db schema patch (http://tinyurl.com/ykkwb97) has already been approved.
This branch is based on the respective schema patch branch (lp:~al-maisan/launchpad/psds-399186). The *actual* diff for it is here:

    http://pastebin.ubuntu.com/302886/

Tests to run:

    bin/test -vvt packageset

No pertinent "make lint" errors or warnings.

[Brad Crittenden (bac)]

Hi Muharem,

Thanks for the branch. It looks good except for the following small items:

* Line 46 - End of line comments are discouraged by our coding standards. Please move to the previous line.

* I think "The person who owns the package set at hand." would read better for most users as "The person who owns this package set."

* Lines 91,110 - Capitalize Ubuntu.

* Line 383 - typo 'dupliacte'

review: Approve (code)

[Muharem Hrnjadovic (al-maisan)]

Brad Crittenden wrote:
> Review: Approve code
> Hi Muharem,
>
> Thanks for the branch. It looks good except for the following small items:
>
> * Line 46 - End of line comments are discouraged by our coding standards. Please move to the previous line.
>
> * I think "The person who owns the package set at hand." would read better for most users as "The person who owns this package set."
>
> * Lines 91,110 - Capitalize Ubuntu.
>
> * Line 383 - typo 'dupliacte'

Hello Brad,

thank you very much for the review! I have revised the branch to
accommodate your suggestions.

Best regards

--
Muharem Hrnjadovic <email address hidden>
Public key id : B2BBFCFC
Key fingerprint : A5A3 CC67 2B87 D641 103F 5602 219F 6B60 B2BB FCFC

=== modified file 'database/schema/comments.sql'
--- database/schema/comments.sql	2009-10-07 12:54:03 +0000
+++ database/schema/comments.sql	2009-10-27 23:43:13 +0000
@@ -2239,11 +2239,20 @@
 
 -- Packageset
 
-COMMENT ON TABLE Packageset IS 'Package sets facilitate the grouping of packages for purposes like the control of upload permissions, et.';
+COMMENT ON TABLE Packageset IS 'Package sets facilitate the grouping of packages (in a given distro series) for purposes like the control of upload permissions, etc.';
 COMMENT ON COLUMN Packageset.date_created IS 'Date and time of creation.';
 COMMENT ON COLUMN Packageset.owner IS 'The Person or team who owns the package set';
 COMMENT ON COLUMN Packageset.name IS 'The name for the package set on hand.';
 COMMENT ON COLUMN Packageset.description IS 'The description for the package set on hand.';
+COMMENT ON COLUMN Packageset.packagesetgroup IS 'The group this package set is affiliated with.';
+COMMENT ON COLUMN Packageset.distroseries IS 'The distro series this package set belongs to.';
+
+-- PackagesetGroup
+
+COMMENT ON TABLE PackagesetGroup IS 'Package set groups keep track of equivalent package sets across distro series boundaries.';
+COMMENT ON COLUMN Packageset.date_created IS 'Date and time of creation.';
+COMMENT ON COLUMN Packageset.owner IS 'The Person or team who owns the package
+set group.';
 
 -- PackagesetSources
 
 
=== added file 'database/schema/patch-2207-06-0.sql'
--- database/schema/patch-2207-06-0.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2207-06-0.sql	2009-10-27 23:43:13 +0000
@@ -0,0 +1,122 @@
+-- Copyright 2009 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+-- ** PART 1 ** Create the 'packagesetgroup' table and the
+--              'packageset.packagesetgroup' foreign key,
+--              populate the 'packagesetgroup' table
+
+-- This table keeps track of package sets that are equivalent across
+-- distro series boundaries.
+CREATE SEQUENCE packagesetgroup_id_seq
+    START WITH 1
+    INCREMENT BY 1
+    NO MAXVALUE
+    NO MINVALUE
+    CACHE 1;
+CREATE TABLE packagesetgroup (
+    id integer NOT NULL DEFAULT nextval('packagesetgroup_id_seq'),
+    date_created timestamp without time zone DEFAULT timezone('UTC'::text, now()) NOT NULL,
+    owner integer NOT NULL,
+    -- Please note: the 'name' column is only here to ease the data migration
+    -- and will be dropped at the end of this patch.
+    name text NOT NULL
+);
+ALTER SEQUENCE packagesetgroup_id_seq OWNED BY packagesetgroup.id;
+ALTER TABLE ONLY packagesetgroup
+    ADD CONSTRAINT packagesetgroup_pkey PRIMARY KEY (id);
+ALTER TABLE ONLY packagesetgroup
+    ADD CONSTRAINT packagesetgroup__owner__fk
+    FOREIGN KEY (owner) REFERENCES person(id);
+
+-- Package sets and their clones belong to the same package set group.
+ALTER TABLE ONLY packageset ADD COLUMN packagesetgroup integer;
+ALTER TABLE ONLY packageset
+  ADD CONSTRAINT packageset__packagesetgroup__fk
+  FOREIGN KEY (packagesetgroup) REFERENCES packagesetgroup(id);
+
+-- Create a group for each of the original (karmic koala) package sets.
+INSERT INTO packagesetgroup(owner, name)
+SELECT packageset.owner, packageset.name
+FROM packageset WHERE NOT packageset.name LIKE('lucid-%');
+
+
+-- ** PART 2 ** Associate the karmic koala package sets and their lucid lynx
+--              clones with the appropriate package set groups
+
+-- Update the karmic koala package sets so they reference their groups.
+UPDATE packageset SET packagesetgroup = packagesetgroup.id
+FROM packagesetgroup WHERE packageset.name = packagesetgroup.name;
+
+-- Update the lucid lynx package set *clones* so they reference their groups
+-- as well.
+UPDATE packageset SET packagesetgroup = packagesetgroup.id
+FROM packagesetgroup WHERE packageset.name = 'lucid-' || packagesetgroup.name;
+
+-- ** PART 3 ** Add the 'packageset.distroseries' foreign key and
+--              initialise it for the existing package sets.
+
+-- A package set lives in a distro series context.
+ALTER TABLE ONLY packageset ADD COLUMN distroseries integer;
+
+-- Define the foreign key constraint.
+ALTER TABLE ONLY packageset
+  ADD CONSTRAINT packageset__distroseries__fk
+  FOREIGN KEY (distroseries) REFERENCES distroseries(id);
+
+-- First migrate the original package sets created for the karmic koala.
+UPDATE packageset SET distroseries = distroseries.id FROM distroseries
+WHERE distroseries.name = 'karmic' AND NOT packageset.name LIKE('lucid-%');
+
+-- Migrate the lucid lynx package sets next.
+UPDATE packageset SET distroseries = distroseries.id FROM distroseries
+WHERE distroseries.name = 'lucid' AND packageset.name LIKE('lucid-%');
+
+-- Make the 'distroseries' foreign key mandatory.
+ALTER TABLE ONLY packageset ALTER COLUMN distroseries SET NOT NULL;
+
+-- The package set name is now only unique in conjunction with a distro series.
+ALTER TABLE ONLY packageset
+    DROP CONSTRAINT packageset_name_key;
+ALTER TABLE ONLY packageset
+    ADD CONSTRAINT packageset__name__distroseries__key UNIQUE (name, distroseries);
+
+-- ** PART 4 ** Strip off the 'lucid-' prefix of the lucid lynx
+--              package set names
+UPDATE packageset SET name = substring(name FROM length('lucid-')+1)
+WHERE name LIKE('lucid-%');
+
+-- ** PART 5 ** Create package set groups for package sets that were added in
+--              lucid lynx but do not exist in the karmic koala,
+--              associate these package sets with their newly created groups
+INSERT INTO packagesetgroup(owner, name)
+SELECT packageset.owner, packageset.name
+FROM packageset, distroseries WHERE
+    packageset.packagesetgroup IS NULL
+    AND packageset.distroseries = distroseries.id
+    AND distroseries.name = 'lucid';
+
+UPDATE packageset SET packagesetgroup = packagesetgroup.id
+FROM packagesetgroup, distroseries
+WHERE
+    packageset.packagesetgroup IS NULL
+    AND packageset.distroseries = distroseries.id
+    AND distroseries.name = 'lucid'
+    AND packageset.name = packagesetgroup.name;
+
+-- ** PART 6 ** Make the 'packageset.packagesetgroup' foreign key mandatory
+ALTER TABLE ONLY packageset ALTER COLUMN packagesetgroup SET NOT NULL;
+
+-- ** PART 7 ** Drop the 'packagesetgroup.name' column that was only added
+--              for data migration purposes.
+ALTER TABLE ONLY packagesetgroup DROP COLUMN name;
+
+-- Define indices on the newly added foreign keys.
+CREATE INDEX packageset__packagesetgroup__idx
+    ON packageset(packagesetgroup);
+CREATE INDEX packageset__distroseries__idx
+    ON packageset(distroseries);
+CREATE INDEX packagesetgroup__owner__idx ON PackageSetGroup(owner);
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2207, 06, 0);
 
=== modified file 'database/schema/security.cfg'
--- database/schema/security.cfg	2009-10-15 23:26:39 +0000
+++ database/schema/security.cfg	2009-10-27 23:43:13 +0000
@@ -226,6 +226,7 @@
 public.packagediff                      = SELECT, INSERT, UPDATE, DELETE
 public.packagediff                      = SELECT, INSERT, UPDATE, DELETE
 public.packageset                       = SELECT, INSERT, UPDATE, DELETE
+public.packagesetgroup                  = SELECT, INSERT, UPDATE, DELETE
 public.packagesetsources                = SELECT, INSERT, UPDATE, DELETE
 public.packagesetinclusion              = SELECT, INSERT, UPDATE, DELETE
 public.flatpackagesetinclusion          = SELECT, INSERT, UPDATE, DELETE
@@ -777,6 +778,7 @@
 public.packagecopyrequest                       = SELECT, INSERT, UPDATE
 public.packagediff                              = SELECT, INSERT, UPDATE
 public.packageset                               = SELECT
+public.packagesetgroup                          = SELECT
 public.packagesetsources                        = SELECT, INSERT, UPDATE, DELETE
 public.packagesetinclusion                      = SELECT, INSERT, UPDATE, DELETE
 public.flatpackagesetinclusion                  = SELECT, INSERT, UPDATE, DELETE
@@ -854,6 +856,7 @@
 public.teammembership                           = SELECT
 public.gpgkey                                   = SELECT
 public.packageset                               = SELECT
+public.packagesetgroup                          = SELECT
 public.packagesetsources                        = SELECT
 public.packagesetinclusion                      = SELECT
 public.flatpackagesetinclusion                  = SELECT
@@ -1054,6 +1057,7 @@
 public.archive                          = SELECT, INSERT, UPDATE
 public.archivearch                      = SELECT, INSERT, UPDATE
 public.packageset                       = SELECT
+public.packagesetgroup                  = SELECT
 public.packagesetsources                = SELECT
 public.packagesetinclusion              = SELECT
 public.flatpackagesetinclusion          = SELECT
@@ -1242,6 +1246,7 @@
 public.personlanguage                   = SELECT
 public.structuralsubscription           = SELECT
 public.packageset                       = SELECT
+public.packagesetgroup                  = SELECT
 public.packagesetsources                = SELECT
 public.packagesetinclusion              = SELECT
 public.flatpackagesetinclusion          = SELECT
 
=== modified file 'database/schema/trusted.sql'
--- database/schema/trusted.sql	2009-08-19 15:35:13 +0000
+++ database/schema/trusted.sql	2009-10-27 23:43:13 +0000
@@ -1029,7 +1029,22 @@
     DECLARE
         parent_name text;
         child_name text;
+        parent_distroseries text;
+        child_distroseries text;
     BEGIN
+        -- Make sure that the package sets being associated here belong
+        -- to the same distro series.
+        IF (SELECT parent.distroseries != child.distroseries
+            FROM packageset parent, packageset child
+            WHERE parent.id = NEW.parent AND child.id = NEW.child)
+        THEN
+            SELECT name INTO parent_name FROM packageset WHERE id = NEW.parent;
+            SELECT name INTO child_name FROM packageset WHERE id = NEW.child;
+            SELECT ds.name INTO parent_distroseries FROM packageset ps, distroseries ds WHERE ps.id = NEW.parent AND ps.distroseries = ds.id;
+            SELECT ds.name INTO child_distroseries FROM packageset ps, distroseries ds WHERE ps.id = NEW.child AND ps.distroseries = ds.id;
+            RAISE EXCEPTION 'Package sets % and % belong to different distro series (to % and % respectively) and thus cannot be associated.', child_name, parent_name, child_distroseries, parent_distroseries;
+        END IF;
+
         IF EXISTS(
             SELECT * FROM flatpackagesetinclusion
             WHERE parent = NEW.child AND child = NEW.parent LIMIT 1)
 
=== modified file 'lib/lp/soyuz/configure.zcml'
--- lib/lp/soyuz/configure.zcml	2009-10-05 13:31:09 +0000
+++ lib/lp/soyuz/configure.zcml	2009-10-27 23:43:13 +0000
@@ -856,4 +856,12 @@
                 new"/>
     </securedutility>
 
+    <!-- PackagesetGroup -->
+    <class
+        class="lp.soyuz.model.packagesetgroup.PackagesetGroup">
+        <allow
+            interface="lp.soyuz.interfaces.packagesetgroup.IPackagesetGroup"/>
+    </class>
+
+
 </configure>
 
=== modified file 'lib/lp/soyuz/interfaces/packageset.py'
--- lib/lp/soyuz/interfaces/packageset.py	2009-07-25 16:33:39 +0000
+++ lib/lp/soyuz/interfaces/packageset.py	2009-10-27 23:43:13 +0000
@@ -8,6 +8,7 @@
 __metaclass__ = type
 
 __all__ = [
+    'DuplicatePackagesetName',
     'IPackageset',
     'IPackagesetSet',
     'NoSuchPackageSet',
@@ -26,16 +27,25 @@
     operation_parameters, operation_returns_collection_of,
     operation_returns_entry, webservice_error)
 from lazr.restful.fields import Reference
+from lp.registry.interfaces.distroseries import IDistroSeries
 from lp.registry.interfaces.person import IPerson
 from lp.registry.interfaces.role import IHasOwner
+from lp.soyuz.interfaces.packagesetgroup import IPackagesetGroup
 
 
 class NoSuchPackageSet(NameLookupFailed):
     """Raised when we try to look up an PackageSet that doesn't exist."""
-    webservice_error(400) #Bad request.
+    # Bad request.
+    webservice_error(400)
     _message_prefix = "No such packageset"
 
 
+class DuplicatePackagesetName(Exception):
+    """Raised for packagesets with the same name and distroseries."""
+    # Bad request.
+    webservice_error(400)
+
+
 class IPackagesetViewOnly(IHasOwner):
     """A read-only interface for package sets."""
     export_as_webservice_entry()
@@ -48,7 +58,7 @@
 
     owner = exported(Reference(
         IPerson, title=_("Person"), required=True, readonly=True,
-        description=_("The person who owns the package set at hand.")))
+        description=_("The person who owns this package set.")))
 
     name = exported(TextLine(
         title=_('Valid package set name'),
@@ -58,6 +68,18 @@
         title=_("Description"), required=True, readonly=True,
         description=_("The description for the package set at hand.")))
 
+    distroseries = Reference(
+        IDistroSeries, title=_("Distribution series"), required=True,
+        readonly=True,
+        description=_(
+            "The distroseries to which this package set is related."))
+
+    packagesetgroup = Reference(
+        IPackagesetGroup, title=_('Packageset group'), required=True,
+        readonly=True,
+        description=_(
+            'Used internally to link packagesets across distroseries'))
+
     def sourcesIncluded(direct_inclusion=False):
         """Get all source names associated with this package set.
 
@@ -316,15 +338,26 @@
             title=_('Package set description'), required=True),
         owner=Reference(
             IPerson, title=_("Person"), required=True, readonly=True,
-            description=_("The person who owns the package set at hand.")))
+            description=_("The person who owns this package set.")),
+        distroseries=Reference(
+            IDistroSeries, title=_("Distroseries"), required=False,
+            readonly=True, description=_(
+                "The distribution series to which the packageset "
+                "is related.")))
     @export_factory_operation(IPackageset, [])
-    def new(name, description, owner):
+    def new(name, description, owner, distroseries=None, related_set=None):
         """Create a new package set.
 
         :param name: the name of the package set to be created.
         :param description: the description for the package set to be created.
         :param owner: the owner of the package set to be created.
+        :param distroseries: the distroseries to which the new packageset
+            is related. Defaults to the current Ubuntu series.
+        :param related_set: the newly created package set is to be related to
+            `related_set` (by being placed in the same package group).
 
+        :raises DuplicatePackagesetName: if a package set with the same `name`
+            exists in `distroseries` already.
         :return: a newly created `IPackageset`.
         """
 
@@ -332,10 +365,12 @@
         name=TextLine(title=_('Package set name'), required=True))
     @operation_returns_entry(IPackageset)
     @export_read_operation()
-    def getByName(name):
+    def getByName(name, distroseries=None):
         """Return the single package set with the given name (if any).
 
         :param name: the name of the package set sought.
+        :param distroseries: the distroseries to which the new packageset
+            is related. Defaults to the current Ubuntu series.
 
         :return: An `IPackageset` instance or None.
         """
 
=== added file 'lib/lp/soyuz/interfaces/packagesetgroup.py'
--- lib/lp/soyuz/interfaces/packagesetgroup.py	1970-01-01 00:00:00 +0000
+++ lib/lp/soyuz/interfaces/packagesetgroup.py	2009-10-27 23:43:13 +0000
@@ -0,0 +1,41 @@
+# Copyright 2009 Canonical Ltd.  This software is licensed under the
+# GNU Affero General Public License version 3 (see the file LICENSE).
+
+"""Packageset Group interface."""
+
+__metaclass__ = type
+
+__all__ = [
+    'IPackagesetGroup',
+    ]
+
+from zope.schema import Datetime, Int
+
+from lazr.restful.fields import Reference
+
+from canonical.launchpad import _
+from lp.registry.interfaces.person import IPerson
+from lp.registry.interfaces.role import IHasOwner
+
+
+class IPackagesetGroup(IHasOwner):
+    """A group of related package sets across distroseries' 
+
+    This class is used internally to group related packagesets across
+    distroseries.  For example, if in Karmic there is a 'gnome-games'
+    package set, and this package set is cloned initially for Lucid,
+    then both packagesets would refer to the same packageset-group.
+
+    Packageset-groups are not exposed at all.  The date_created and
+    owner fields are present for internal use only.
+    """
+    id = Int(title=_('ID'), required=True, readonly=True)
+
+    date_created = Datetime(
+        title=_("Date Created"), required=True, readonly=True,
+        description=_("The creation date/time for this packageset group."))
+
+    owner = Reference(
+        IPerson, title=_("Person"), required=True, readonly=True,
+        description=_("The person who created this packageset group."))
+
 
=== modified file 'lib/lp/soyuz/model/packageset.py'
--- lib/lp/soyuz/model/packageset.py	2009-07-25 16:33:39 +0000
+++ lib/lp/soyuz/model/packageset.py	2009-10-27 23:43:13 +0000
@@ -6,6 +6,7 @@
 
 import pytz
 
+from storm.exceptions import IntegrityError
 from storm.expr import In, SQL
 from storm.locals import DateTime, Int, Reference, Storm, Unicode
 
@@ -13,12 +14,13 @@
 from zope.interface import implements
 
 from canonical.launchpad.interfaces.lpstorm import IMasterStore, IStore
+from lp.registry.interfaces.distribution import IDistributionSet
 from lp.registry.interfaces.sourcepackagename import (
     ISourcePackageName, ISourcePackageNameSet)
 from lp.registry.model.sourcepackagename import SourcePackageName
 from lp.soyuz.interfaces.packageset import (
-    IPackageset, IPackagesetSet, NoSuchPackageSet)
-
+    DuplicatePackagesetName, IPackageset, IPackagesetSet, NoSuchPackageSet)
+from lp.soyuz.model.packagesetgroup import PackagesetGroup
 
 def _order_result_set(result_set):
     """Default order for package set and source package name result sets."""
@@ -45,6 +47,12 @@
     name = Unicode(name='name', allow_none=False)
     description = Unicode(name='description', allow_none=False)
 
+    distroseries_id = Int(name='distroseries', allow_none=False)
+    distroseries = Reference(distroseries_id, 'DistroSeries.id')
+
+    packagesetgroup_id = Int(name='packagesetgroup', allow_none=False)
+    packagesetgroup = Reference(packagesetgroup_id, 'PackagesetGroup.id')
+
     def add(self, data):
         """See `IPackageset`."""
         handlers = (
@@ -292,26 +300,66 @@
     """See `IPackagesetSet`."""
     implements(IPackagesetSet)
 
-    def new(self, name, description, owner):
+    def new(
+        self, name, description, owner, distroseries=None, related_set=None):
         """See `IPackagesetSet`."""
         store = IMasterStore(Packageset)
+
+        packagesetgroup = None
+        if related_set is not None:
+            # Use the packagesetgroup of the `related_set`.
+            packagesetgroup = related_set.packagesetgroup
+        else:
+            # We create the related internal PackagesetGroup for this
+            # packageset so that we can later see related package sets across
+            # distroserieses.
+            packagesetgroup = PackagesetGroup()
+            packagesetgroup.owner = owner
+            store.add(packagesetgroup)
+
+        if distroseries is None:
+            ubuntu = getUtility(IDistributionSet).getByName('ubuntu')
+            distroseries = ubuntu.currentseries
+
         packageset = Packageset()
+        packageset.packagesetgroup = packagesetgroup
         packageset.name = name
         packageset.description = description
         packageset.owner = owner
+
+        packageset.distroseries = distroseries
+
         store.add(packageset)
+
+        # We need to ensure that the cached statements are flushed so that
+        # the duplicate name constraint gets triggered here.
+        try:
+            store.flush()
+        except IntegrityError:
+            raise DuplicatePackagesetName()
+
         return packageset
 
     def __getitem__(self, name):
         """See `IPackagesetSet`."""
         return self.getByName(name)
 
-    def getByName(self, name):
+    def getByName(self, name, distroseries=None):
         """See `IPackagesetSet`."""
         store = IStore(Packageset)
         if not isinstance(name, unicode):
             name = unicode(name, 'utf-8')
-        package_set = store.find(Packageset, Packageset.name == name).one()
+
+        extra_args = []
+        if distroseries is not None:
+            extra_args.append(Packageset.distroseries == distroseries)
+        else:
+            ubuntu = getUtility(IDistributionSet).getByName('ubuntu')
+            extra_args.append(Packageset.distroseries == ubuntu.currentseries)
+
+        package_set = store.find(
+            Packageset, Packageset.name == name, *extra_args).one()
+
         if package_set is None:
             raise NoSuchPackageSet(name)
         return package_set
 
=== added file 'lib/lp/soyuz/model/packagesetgroup.py'
--- lib/lp/soyuz/model/packagesetgroup.py	1970-01-01 00:00:00 +0000
+++ lib/lp/soyuz/model/packagesetgroup.py	2009-10-27 23:43:13 +0000
@@ -0,0 +1,30 @@
+# Copyright 2009 Canonical Ltd.  This software is licensed under the
+# GNU Affero General Public License version 3 (see the file LICENSE).
+
+__metaclass__ = type
+
+__all__ = [
+    'PackagesetGroup',
+    ]
+
+import pytz
+
+from storm.locals import DateTime, Int, Reference, Storm
+
+from zope.interface import implements
+
+from lp.soyuz.interfaces.packagesetgroup import IPackagesetGroup
+
+
+class PackagesetGroup(Storm):
+    """See `IPackageset`."""
+    implements(IPackagesetGroup)
+    __storm_table__ = 'PackagesetGroup'
+    id = Int(primary=True)
+
+    date_created = DateTime(
+        name='date_created', allow_none=False, tzinfo=pytz.UTC)
+
+    owner_id = Int(name='owner', allow_none=False)
+    owner = Reference(owner_id, 'Person.id')
+
 
=== added file 'lib/lp/soyuz/tests/test_packageset.py'
--- lib/lp/soyuz/tests/test_packageset.py	1970-01-01 00:00:00 +0000
+++ lib/lp/soyuz/tests/test_packageset.py	2009-10-27 23:43:13 +0000
@@ -0,0 +1,121 @@
+# Copyright 2009 Canonical Ltd.  This software is licensed under the
+# GNU Affero General Public License version 3 (see the file LICENSE).
+
+"""Test Packageset features."""
+
+from zope.component import getUtility
+
+from canonical.testing import LaunchpadZopelessLayer
+
+from lp.testing import TestCaseWithFactory
+from lp.registry.interfaces.distribution import IDistributionSet
+from lp.registry.interfaces.distroseries import DistroSeriesStatus
+from lp.soyuz.interfaces.packageset import (
+    DuplicatePackagesetName, IPackagesetSet)
+
+
+class TestPackagesetSetNew(TestCaseWithFactory):
+
+    layer = LaunchpadZopelessLayer
+
+    def setUp(self):
+        """Setup a distribution with multiple distroseries."""
+        super(TestPackagesetSetNew, self).setUp()
+        self.distribution = getUtility(IDistributionSet).getByName(
+            'ubuntu')
+        self.distroseries_current = self.distribution.currentseries
+        self.distroseries_experimental = self.factory.makeDistroRelease(
+            distribution = self.distribution, name="experimental",
+            status=DistroSeriesStatus.EXPERIMENTAL)
+
+        self.person1 = self.factory.makePerson(
+            name='hacker', displayname=u'Happy Hacker')
+
+        self.packageset_set = getUtility(IPackagesetSet)
+
+    def test_new_defaults_to_current_distroseries(self):
+        # If the distroseries is not provided, the current development
+        # distroseries will be assumed.
+        packageset = self.packageset_set.new(
+            u'kernel', u'Contains all OS kernel packages', self.person1)
+
+        self.failUnlessEqual(
+            self.distroseries_current, packageset.distroseries)
+
+    def test_new_with_specified_distroseries(self):
+        # A distroseries can be provided when creating a package set.
+        packageset = self.packageset_set.new(
+            u'kernel', u'Contains all OS kernel packages', self.person1,
+            distroseries=self.distroseries_experimental)
+
+        self.failUnlessEqual(
+            self.distroseries_experimental, packageset.distroseries)
+
+    def test_new_creates_new_packageset_group(self):
+        # Creating a new packageset should also create a new packageset
+        # group with the same owner.
+        packageset = self.packageset_set.new(
+            u'kernel', u'Contains all OS kernel packages', self.person1,
+            distroseries=self.distroseries_experimental)
+
+        self.failUnlessEqual(
+            self.person1, packageset.packagesetgroup.owner)
+
+    def test_new_duplicate_name_for_same_distroseries(self):
+        # Creating a packageset with a duplicate name for the
+        # given distroseries will fail.
+        packageset = self.packageset_set.new(
+            u'kernel', u'Contains all OS kernel packages', self.person1,
+            distroseries=self.distroseries_experimental)
+
+        self.failUnlessRaises(
+            DuplicatePackagesetName, self.packageset_set.new,
+            u'kernel', u'A packageset with a duplicate name', self.person1,
+            distroseries=self.distroseries_experimental)
+
+    def test_new_duplicate_name_for_different_distroseries(self):
+        # Creating a packageset with a duplicate name but for a different
+        # series is no problem.
+        packageset = self.packageset_set.new(
+            u'kernel', u'Contains all OS kernel packages', self.person1)
+
+        packageset2 = self.packageset_set.new(
+            u'kernel', u'A packageset with a duplicate name', self.person1,
+            distroseries=self.distroseries_experimental)
+        self.assertEqual(packageset.name, packageset2.name)
+
+    def test_new_related_packageset(self):
+        # Creating a new package set while specifying a `related_set` should
+        # have the effect that the former ends up in the same group as the
+        # latter.
+        pset1 = self.packageset_set.new(
+            u'kernel', u'Contains all OS kernel packages', self.person1)
+
+        pset2 = self.packageset_set.new(
+            u'kernel', u'A related package set.', self.person1,
+            distroseries=self.distroseries_experimental, related_set=pset1)
+        self.assertEqual(pset1.packagesetgroup, pset2.packagesetgroup)
+
+    def test_get_by_name_in_current_distroseries(self):
+        # IPackagesetSet.getByName() will return the package set in the
+        # current distroseries if the optional `distroseries` parameter is
+        # omitted.
+        pset1 = self.packageset_set.new(
+            u'kernel', u'Contains all OS kernel packages', self.person1)
+        pset2 = self.packageset_set.new(
+            u'kernel', u'A related package set.', self.person1,
+            distroseries=self.distroseries_experimental, related_set=pset1)
+        pset_found = getUtility(IPackagesetSet).getByName('kernel')
+        self.assertEqual(pset1, pset_found)
+
+    def test_get_by_name_in_specified_distroseries(self):
+        # IPackagesetSet.getByName() will return the package set in the
+        # specified distroseries.
+        pset1 = self.packageset_set.new(
+            u'kernel', u'Contains all OS kernel packages', self.person1)
+        pset2 = self.packageset_set.new(
+            u'kernel', u'A related package set.', self.person1,
+            distroseries=self.distroseries_experimental, related_set=pset1)
+        pset_found = getUtility(IPackagesetSet).getByName(
+            'kernel', distroseries=self.distroseries_experimental)
+        self.assertEqual(pset2, pset_found)