Merge ~akaris/cloud-init:bug1684349 into cloud-init:master
Proposed by
Andreas Karis
Status: | Merged |
---|---|
Merged at revision: | 16a7302f6acb69adb0aee75eaf12392fa3688853 |
Proposed branch: | ~akaris/cloud-init:bug1684349 |
Merge into: | cloud-init:master |
Diff against target: |
16 lines (+2/-2) 1 file modified
cloudinit/net/network_state.py (+2/-2) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Chad Smith | Needs Fixing | ||
Server Team CI bot | continuous-integration | Approve | |
cloud-init Commiters | Pending | ||
Review via email: mp+322992@code.launchpad.net |
Commit message
Fix mask2cidr error with integer value
mask2cidr error with integer value - argument of type 'int' is not iterable. Method mask2cidr is not type safe. It tries to take into account that this can be a prefix (so it does not contain ':' nor '.') and then simly return mask without action. The problem is that if mask is an integer, then this throws an error, so this patch casts mask to type string in the if/elif.
LP: #1684349
To post a comment you must log in.
PASSED: Continuous integration, rev:4f75b2d0962 a48abbaa6af78d6 63ac4a30af356c /jenkins. ubuntu. com/server/ job/cloud- init-ci/ 264/ /jenkins. ubuntu. com/server/ job/cloud- init-ci/ nodes=metal- amd64/264 /jenkins. ubuntu. com/server/ job/cloud- init-ci/ nodes=metal- arm64/264 /jenkins. ubuntu. com/server/ job/cloud- init-ci/ nodes=metal- ppc64el/ 264 /jenkins. ubuntu. com/server/ job/cloud- init-ci/ nodes=metal- s390x/264 /jenkins. ubuntu. com/server/ job/cloud- init-ci/ nodes=vm- i386/264
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild: /jenkins. ubuntu. com/server/ job/cloud- init-ci/ 264/rebuild
https:/