Merge ~aieri/charm-nagios:bug/1864192-rebase into ~nagios-charmers/charm-nagios:master
Proposed by
Andrea Ieri
Status: | Merged |
---|---|
Merged at revision: | 233cd954f1327a47c5dca132c10a1a55c299c44f |
Proposed branch: | ~aieri/charm-nagios:bug/1864192-rebase |
Merge into: | ~nagios-charmers/charm-nagios:master |
Prerequisite: | ~aieri/charm-nagios:bug/1864192-charmhelpers-sync |
Diff against target: |
170 lines (+74/-58) 2 files modified
hooks/common.py (+0/-20) hooks/monitors-relation-changed (+74/-38) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alvaro Uria (community) | Approve | ||
Adam Dyess (community) | Approve | ||
Chris Sanders | Pending | ||
Peter Sabaini | Pending | ||
Review via email: mp+387312@code.launchpad.net |
This proposal supersedes a proposal from 2020-07-13.
To post a comment you must log in.
LGTM, some nits but nothing blocking imo