Merge ~ahasenack/ubuntu/+source/samba:bionic-samba-memleak-1814532 into ubuntu/+source/samba:ubuntu/bionic-devel
Proposed by
Andreas Hasenack
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Christian Ehrhardt | ||||
Approved revision: | 444cd5f91791b08365d84fea9ccb952a47bc6ed6 | ||||
Merge reported by: | Andreas Hasenack | ||||
Merged at revision: | 444cd5f91791b08365d84fea9ccb952a47bc6ed6 | ||||
Proposed branch: | ~ahasenack/ubuntu/+source/samba:bionic-samba-memleak-1814532 | ||||
Merge into: | ubuntu/+source/samba:ubuntu/bionic-devel | ||||
Diff against target: |
74 lines (+52/-0) 3 files modified
debian/changelog (+7/-0) debian/patches/memleak-fix-13372.patch (+44/-0) debian/patches/series (+1/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christian Ehrhardt (community) | Approve | ||
Canonical Server | Pending | ||
Review via email: mp+362700@code.launchpad.net |
Description of the change
Fix for a memleak.
There is no real test case for this. I tried running smbd under valgrind before and after installing the fixed packages, but I'm not sure if it's robust enough. I added the results to https:/
Bileto ticket: https:/
It's all green: gvfs on s390x is a known and already hinted failure.
Bug has the SRU template, but the test case is lacking as explained above.
To post a comment you must log in.
I'm still reviewing, but to make the valgrind data better I'd suggest to install debug packages of the to be debugged program.
When calling it with valgrind add this to the arguments:
--leak-check=full --track-origins=yes
Post back that info here or on the bug, it might help to feel more convinced of the change.