Merge lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-reference-is-not-defined into lp:~hr-core-editors/hr-timesheet/7.0

[Lorenzo Battistini]

[FIX]
File "/home/elbati/workspace/openerp/progetti/agilebg/git/agilebg/parts/hr-timesheet-7.0/hr_attendance_analysis/wizard/print_calendar_report.py", line 160, in print_calendar
    for calendar_attendance in reference.attendance_ids:
NameError: global name 'reference' is not defined

[Pedro Manuel Baeza (pedro.baeza)]

LGTM.

Regards.

review: Approve (code review)

[lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-reference-is-not-defined]

69. By Alex Comba - Agile BG on 2014-07-11

[MRG] Merged upstream

[Pedro Manuel Baeza (pedro.baeza)]

This project is now hosted on https://github.com/OCA/hr-timesheet. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting

[Alex Comba - Agile BG (tafaru)]

Moved to https://github.com/OCA/hr-timesheet/pull/7
I prefer do not delete the proposal to keep all the associated comments that have been made.

review: Disapprove

Unmerged revisions

69. By Alex Comba - Agile BG on 2014-07-11

[MRG] Merged upstream

68. By Lorenzo Battistini on 2014-05-28

[FIX]
File "/home/elbati/workspace/openerp/progetti/agilebg/git/agilebg/parts/hr-timesheet-7.0/hr_attendance_analysis/wizard/print_calendar_report.py", line 160, in print_calendar
    for calendar_attendance in reference.attendance_ids:
NameError: global name 'reference' is not defined

=== modified file 'hr_attendance_analysis/wizard/print_calendar_report.py'
--- hr_attendance_analysis/wizard/print_calendar_report.py	2013-11-19 13:32:00 +0000
+++ hr_attendance_analysis/wizard/print_calendar_report.py	2014-07-11 07:04:37 +0000
@@ -157,7 +157,7 @@
                 if reference_calendar:
                     if reference_calendar.attendance_ids:
                         current_total_due = 0.0
-                        for calendar_attendance in reference.attendance_ids:
+                        for calendar_attendance in reference_calendar.attendance_ids:
                             if ((
                                 not calendar_attendance.dayofweek
                                 or int(calendar_attendance.dayofweek) == current_date.weekday()