Merge lp:~adeuring/launchpad/security-guarded-test-object-factory-3 into lp:launchpad
Status: | Rejected |
---|---|
Rejected by: | Abel Deuring |
Proposed branch: | lp:~adeuring/launchpad/security-guarded-test-object-factory-3 |
Merge into: | lp:launchpad |
Diff against target: |
176 lines (+37/-19) 4 files modified
lib/lp/bugs/doc/bug-heat.txt (+7/-4) lib/lp/bugs/tests/test_bugheat.py (+21/-8) lib/lp/code/browser/tests/test_branchmergeproposal.py (+3/-2) lib/lp/testing/factory.py (+6/-5) |
To merge this branch: | bzr merge lp:~adeuring/launchpad/security-guarded-test-object-factory-3 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Henning Eggers (community) | code | Abstain | |
Aaron Bentley | Pending | ||
Review via email: mp+30917@code.launchpad.net |
Description of the change
this branch is another sequel to ensure that objects returned by methods of LPObjectFactory are wrapped in security proxies. It changes the methods makeBranchMerge
See also the branches lp:~adeuring/launchpad/security-guarded-test-object-factory-1 and ~adeuring/
Unmerged revisions
- 11164. By Abel Deuring
-
trunk merged
- 11163. By Abel Deuring
-
fixed test failures in bug-heat.txt
- 11162. By Abel Deuring
-
fixed test failures in test_bugheat.py
- 11161. By Abel Deuring
-
trunk merged
- 11160. By Abel Deuring
-
parent branch merged
- 11159. By Abel Deuring
-
add securoty proxies to the result returned by LaunchpadObject
Factory. makeBranchMerge Proposal( ) and LaunchpadObject Factory. makeDistributio nSourcePackage( ) - 11158. By Abel Deuring
-
fixed a failing test in test_braachmerg
eproposal. py - 11157. By Abel Deuring
-
let LaunchpadObject
Factory. makeCodeReviewV oteReference( ) and LaunchpadObject Factory. makeBinaryPacka gePublishingHis tory() return security proxied objects
erm, tests: All those that I changed.
No newly introduced lint.