lp:~adam-collard/maas

Author: Adam Collard
Author Date: 2022-07-28 14:35:21 UTC

Don't get_machine_default_gateway every few minutes

Partial fix for LP:1978225

Signed-off-by: Adam Collard <adam.collard@canonical.com>

Author: Adam Collard
Author Date: 2022-07-14 09:14:54 UTC

LP:1970803 Event query filters AUDIT by nodes like other levels

Author: Alberto Donato
Author Date: 2022-06-13 07:20:17 UTC

update snap config for core22 base

Author: Adam Collard
Author Date: 2022-07-01 07:24:06 UTC

Remove testtools matchers

Signed-off-by: Adam Collard <adam.collard@canonical.com>

Author: Adam Collard
Author Date: 2022-06-28 14:40:22 UTC

Fix use of undefined LINUX_OSYSTEMS

Signed-off-by: Adam Collard <adam.collard@canonical.com>

Author: Adam Collard
Author Date: 2022-06-27 14:55:05 UTC

When enabling debug on a rack+region install, set debug for rackd

Author: Adam Collard
Author Date: 2022-06-24 10:17:44 UTC

Migrate MAASTwistedRunTest callers to use global TIMEOUT

Author: Adam Collard
Author Date: 2022-06-22 16:53:44 UTC

Prefer curl over wget for UI dependencies

Stream curl straight into tar to avoid wasted space on disk.

Nobody needs tarballs of yarn and nodejs kicking around.

Signed-off-by: Adam Collard <adam.collard@canonical.com>

Author: Adam Collard
Author Date: 2022-06-21 16:17:28 UTC

Add wget as a build-package for the ui snap

Author: Adam Collard
Author Date: 2022-06-21 09:56:42 UTC

LP:1978154: Don't require netplan for custom CentOS images

We erroneously checked custom CentOS images for netplan, remove that.

Switch to using `rpm -q` for package installation (a more reaonable
translation of `dpkq-query -s`)

Validate RHEL based custom images too.

(cherry picked from commit 9877850af9d3ba9d281b5de9518c9997d0d25dc9 )

Author: Adam Collard
Author Date: 2022-06-21 09:50:19 UTC

Add debug logging for LXD power state changes

Author: Adam Collard
Author Date: 2022-06-17 16:04:53 UTC

Add info to help understand what happened when crochet tests timeout

Author: Adam Collard
Author Date: 2022-06-17 12:43:54 UTC

Refactor: extract timedelta to seconds

Author: Adam Collard
Author Date: 2022-06-16 12:54:42 UTC

LP:1978154: Don't require netplan for custom CentOS images

We erroneously checked custom CentOS images for netplan, remove that.

Switch to using `rpm -q` for package installation (a more reaonable
translation of `dpkq-query -s`)

Validate RHEL based custom images too.

Author: Adam Collard
Author Date: 2022-05-27 17:06:30 UTC

Black

Author: Adam Collard
Author Date: 2022-05-27 16:56:32 UTC

Squash multiple dbupgrade tests into one

Whilst undesirable from a unit-testing perspective, these tests are
not unit tests. The dbupgrade call will take > 15s since it sets up a
new PostgreSQL cluster and runs the migrations. Instead we collect all
of the pre- and post- migration tests and perform them all in batch.

Author: Adam Collard
Author Date: 2022-05-27 13:13:32 UTC

Fix flaky test trying to generate a shared secret

End result to wait 60s instead of 10s

Author: Adam Collard
Author Date: 2022-05-25 15:40:55 UTC

Switch UI from master to main

Author: Adam Collard
Author Date: 2022-05-25 09:05:32 UTC

Fix tests

Author: Adam Collard
Author Date: 2022-03-25 18:03:21 UTC

Fix flaky test which leaked state into power_action_registry

Author: Adam Collard
Author Date: 2022-04-26 15:56:56 UTC

ack's feedback - deferToDatabase once

Author: Adam Collard
Author Date: 2022-04-22 17:08:06 UTC

Fix preamble of API docs

Author: Adam Collard
Author Date: 2022-04-21 13:59:54 UTC

Addressing ack's review comments

More f-string

Name the regex groups

Author: Adam Collard
Author Date: 2022-04-20 12:31:09 UTC

No need for node-sass (nor python 2) anymore

393c6ef8ac50fadf6938335480c6d2542da0bc5b in maas-ui removed the need
for node-sass

Author: Adam Collard
Author Date: 2022-04-06 09:16:23 UTC

Remove all hard-coded times for wait_for()

Defer timeout calculation to the MAAS_WAIT_FOR_REACTOR environment
variable, defaulting to 60s.

Author: Adam Collard
Author Date: 2022-03-25 12:30:04 UTC

Skip performance tests by default when invoking perftest

Add --perf to pytest cmdline to run them

Author: Adam Collard
Author Date: 2022-03-25 09:40:27 UTC

Add Cog to manage pytest files

By putting all pytest tests in pytest_tests directories, they will be
ignored by nose, and run by pytest.

Author: Adam Collard
Author Date: 2022-03-24 18:13:42 UTC

Update docs of tags.update_nodes

Author: Adam Collard
Author Date: 2022-03-24 17:50:32 UTC

[ack's review] Convert log to f-string

Author: Adam Collard
Author Date: 2022-03-21 15:10:34 UTC

Tweak script processing to use dictionary

Adjust test to be more unit-like and less integration-like.

Author: Adam Collard
Author Date: 2022-03-22 17:49:58 UTC

Don't try and collect (and then filter out) all the tests

Author: Adam Collard
Author Date: 2022-03-21 15:31:36 UTC

Bump timeout for LXD tests on CI

Author: Adam Collard
Author Date: 2022-03-07 17:46:51 UTC

Add dirty_db_usage property to MAASTransactionServerTestCase

Re-factor node tests to minimise transaction test cases, mark clean
where the tests don't effect each other.

Author: Adam Collard
Author Date: 2021-09-20 09:31:19 UTC

Remove http{,s}_proxy from environ, unskip test

Author: Adam Collard
Author Date: 2022-03-11 16:55:21 UTC

Clean up tempfiles

Author: Adam Collard
Author Date: 2022-03-11 10:56:06 UTC

Speed up node tests

Author: Adam Collard
Author Date: 2022-03-09 17:51:16 UTC

Ack's feedback

Author: Adam Collard
Author Date: 2022-03-09 14:49:35 UTC

Fixes to update-initial-sql

Author: Adam Collard
Author Date: 2022-03-09 11:06:36 UTC

Allow no-op closing of a disabled connection.

Author: Adam Collard
Author Date: 2022-03-08 17:03:25 UTC

Speed up websocket tests

Author: Adam Collard
Author Date: 2022-03-08 14:02:35 UTC

Update initial SQL

Author: Adam Collard
Author Date: 2022-03-08 12:36:27 UTC

[ack's review] dedent, use Path.read_text()

Author: Adam Collard
Author Date: 2022-03-08 12:28:28 UTC

Isolate bmc_config test from machine where /dev/ipmi\d exists

Author: Adam Collard
Author Date: 2022-03-08 12:20:48 UTC

Fix flaky test

Author: Adam Collard
Author Date: 2022-03-07 11:10:41 UTC

Encapsulate how to pick (ack's review)

Author: Adam Collard
Author Date: 2022-03-03 10:13:08 UTC

Remove unused fields from machine list

- cpu_speed
- commissioning_start_time
- commissioning_status

Author: Adam Collard
Author Date: 2022-03-03 10:17:24 UTC

Remove MachineHandler from ControllerHandler base class

Move Controller to inherit from Node (it is a Node, it is not a
Machine)

Add helper for processing things common to nodes

Author: Adam Collard
Author Date: 2022-03-03 09:15:41 UTC

Remove hostname from update tests

Author: Adam Collard
Author Date: 2022-03-01 13:37:19 UTC

Rewrite test to avoid flakiness

Author: Adam Collard
Author Date: 2021-07-09 10:52:18 UTC

Don't create node_devices by default in make_Node()

Author: Adam Collard
Author Date: 2022-02-24 17:55:53 UTC

Quieten down the fetching of node and yarn binaries

Author: Adam Collard
Author Date: 2022-02-04 14:34:38 UTC

Add pinned jedi dependency to work well with IPython

Author: Adam Collard
Author Date: 2021-12-02 15:00:03 UTC

Move lsblk output to JSON (instead of pairs)

Author: Adam Collard
Author Date: 2021-12-01 10:30:28 UTC

Add support for snapcraft 6.0

Fix PYTHONPATH to remove $SNAP from build-environment

Signed-off-by: Adam Collard <adam.collard@canonical.com>

Author: Adam Collard
Author Date: 2021-11-04 14:25:43 UTC

Add test for vmcluster vm_count

Pass project through to Pod in factory

Author: Adam Collard
Author Date: 2021-11-03 12:29:18 UTC

Pop decompose from params before passing through to vmcluster

Author: Adam Collard
Author Date: 2021-10-07 16:04:21 UTC

Migrate iprange tests to unittest assertRaises

Don't validate issues on .save(), which pollutes postgres logs. Test
.clean() and variants thereof

Author: Adam Collard
Author Date: 2021-10-07 11:01:51 UTC

Remove unused maasserver.sequence.Sequence methods

maasserver.sequence.Sequence is only used once, by zone_serial and
that doesn't use half the methods.

This should reduce postgresql log noise

Signed-off-by: Adam Collard <adam.collard@canonical.com>

Author: Adam Collard
Author Date: 2021-09-30 13:49:18 UTC

Update test schema to minimise work to migrate.

Author: Adam Collard
Author Date: 2021-09-29 09:21:42 UTC

Re-add machine-resources since it's called elsewhere

notably provisioningserver.utils.ipaddr.get_ip_addr()

Author: Adam Collard
Author Date: 2021-09-27 11:17:50 UTC

Don't set Content-Length for a response we want to be streamed

Author: Adam Collard
Author Date: 2021-09-23 09:25:56 UTC

[tests/websockets] Do not re-register triggers

Triggers are registered across the whole test suite via maasserver.testing.resources.DjangoPristineDatabaseManager.

Author: Adam Collard
Author Date: 2021-09-22 16:05:21 UTC

[release-status] Add revision information to SnapsUploaded

Author: Adam Collard
Author Date: 2021-09-20 11:03:48 UTC

Remove deprecated assertItemsEqual

Author: Adam Collard
Author Date: 2021-09-20 09:37:16 UTC

Skip failing test again.

Author: Adam Collard
Author Date: 2021-09-16 12:48:22 UTC

Address feedback from ack

Author: Adam Collard
Author Date: 2021-09-16 09:39:51 UTC

[models] Replace defunct assertItemsEqual

Author: Adam Collard
Author Date: 2021-09-15 14:46:58 UTC

[metadataserver] Replace defunct assertItemsEqual

Author: Adam Collard
Author Date: 2021-09-15 14:20:31 UTC

[forms] Replace defunct assertItemsEqual

Author: Adam Collard
Author Date: 2021-09-14 12:49:01 UTC

[api] Replace defunct assertItemsEqual

Author: Adam Collard
Author Date: 2021-09-14 16:41:35 UTC

[rpc] Replace defunct assertItemsEqual

Author: Adam Collard
Author Date: 2021-09-15 08:33:52 UTC

[websockets] Replace defunct assertItemsEqual

Author: Adam Collard
Author Date: 2021-09-14 11:12:51 UTC

Remove defunct assertItemsEqual in favour of bare assert ==

Author: Adam Collard
Author Date: 2021-09-10 11:18:15 UTC

Drop unittest2, remove wrappers

Author: Adam Collard
Author Date: 2021-09-10 11:29:59 UTC

Remove deprecated (unused) context argument from fields.

Author: Adam Collard
Author Date: 2021-09-10 10:29:59 UTC

Fix broken vcenter registration tests

Author: Adam Collard
Author Date: 2021-09-02 16:52:14 UTC

Speed up middleware detecting disconnected controllers

Author: Adam Collard
Author Date: 2021-09-02 13:41:02 UTC

Minor improvements to release-status to guide on issues

Author: Adam Collard
Author Date: 2021-09-01 09:15:25 UTC

Add system_id to clone errors

Author: Adam Collard
Author Date: 2021-08-31 09:59:39 UTC

Clean up test_security

Author: Adam Collard
Author Date: 2021-08-25 11:13:50 UTC

Don't pick LXD for testing power_parameters skip

Author: Adam Collard
Author Date: 2021-08-25 09:38:11 UTC

ack's nitpick

Author: Adam Collard
Author Date: 2021-08-23 13:18:50 UTC

s/assertItemsEqual/assertCountEqual/g - ack's feedback

Signed-off-by: Adam Collard <adam.collard@canonical.com>

Author: Adam Collard
Author Date: 2021-08-23 08:39:15 UTC

Special case VMFS7 layout too.

Author: Adam Collard
Author Date: 2021-08-20 11:02:51 UTC

Flaky test - we don't care about the order

Author: Adam Collard
Author Date: 2021-08-13 10:39:11 UTC

Remove redundant setup

Author: Adam Collard
Author Date: 2021-08-11 09:43:44 UTC

Tweak clone permissions

Author: Adam Collard
Author Date: 2021-07-12 09:50:21 UTC

Always ensure needle is unique in the NodeDevice haystack

Author: Adam Collard
Author Date: 2021-07-12 10:42:18 UTC

Report the seed info in an easier to copy format

Author: Adam Collard
Author Date: 2021-07-09 13:43:20 UTC

More flaky test squashing.

Config.objects._config_changed_connections
{'http_proxy': {<function update_boot_source_cache>},
 'enable_http_proxy': {<function update_boot_source_cache>},
 'windows_kms_host': {<function dns_kms_setting_changed>},
 'network_discovery': {<function update_interface_monitoring>},
  'completed_intro': set()})

Author: Adam Collard
Author Date: 2021-07-08 09:39:28 UTC

Add __unittest marker to skip this frame from traceback report

Author: Adam Collard
Author Date: 2021-07-07 09:37:58 UTC

Request block devices that are big enough to be bootable in tests

Avoids 'interesting' block devices being picked as boot device and then
failing validation.

Author: Adam Collard
Author Date: 2021-07-01 10:48:49 UTC

Fix flaky bcache test.

When creating a partition table from a partition that is intended to
be bootable, ensure the block device size is >= MIN_BOOT_PARTITION_SIZE.

Signed-off-by: Adam Collard <adam.collard@canonical.com>

Author: Adam Collard
Author Date: 2021-06-22 09:49:37 UTC

Fix flaky websocket handler test with VMFS7 storage layout

Record as a test detail which storage layout we picked, fix bug in
but_not parameter.

Ensure the boot disk is big enough for VMFS7 to fit.

Fix whitespace in error with boot disk size.

Author: Adam Collard
Author Date: 2021-06-24 10:37:38 UTC

Ensure that no generated NodeDevices clash with test fixtures.

Testing that filters work wasn't taking in to account potential clash
with factory-generated NodeDevices.

Author: Adam Collard
Author Date: 2021-06-23 11:21:51 UTC

Filter destination machines by status up front

Author: Adam Collard
Author Date: 2021-06-22 08:47:04 UTC

Fix flaky websocket handler test with VMFS7 storage layout

Record as a test detail which storage layout we picked, fix bug in
but_not parameter.

Ensure the boot disk is big enough for VMFS7 to fit.

Author: Adam Collard
Author Date: 2021-05-04 18:32:19 UTC

Fix flaky test_nodedevices test to not care about order of IDs

Author: Adam Collard
Author Date: 2021-04-20 10:23:43 UTC

Show best possible help for maas cli when missing arguments.

Signed-off-by: Adam Collard <adam.collard@canonical.com>

Author: Adam Collard
Author Date: 2021-04-09 14:49:48 UTC

assert XML, debugging