Merge ~ack/maas:1879978-snap-status-require-root into maas:master

[Alberto Donato]

LP: #1879978 - snap: require running status command as root

[Björn Tillenius (bjornt)]

+1

review: Approve

[Dougal Matthews (d0ugal)]

lgtm

review: Approve

diff --git a/src/maascli/snappy.py b/src/maascli/snappy.py
index 20150d5..e352a59 100644
--- a/src/maascli/snappy.py
+++ b/src/maascli/snappy.py
@@ -1263,6 +1263,9 @@ class cmd_status(SnappyCommand):
     """Status of controller services."""
 
     def handle(self, options):
+        if os.getuid() != 0:
+            raise SystemExit("The 'status' command must be run by root.")
+
         if get_current_mode() == "none":
             print_msg("MAAS is not configured")
             sys.exit(1)
diff --git a/src/maascli/tests/test_snappy.py b/src/maascli/tests/test_snappy.py
index 2540398..4e892d2 100644
--- a/src/maascli/tests/test_snappy.py
+++ b/src/maascli/tests/test_snappy.py
@@ -860,3 +860,14 @@ class TestCmdInit(MAASTestCase):
             },
             settings,
         )
+
+
+class TestCmdStatus(MAASTestCase):
+    def test_requires_root(self):
+        parser = ArgumentParser()
+        cmd = snappy.cmd_status(parser)
+        self.patch(os, "getuid").return_value = 1000
+        error = self.assertRaises(SystemExit, cmd, parser.parse_args([]))
+        self.assertEqual(
+            str(error), "The 'status' command must be run by root."
+        )