Merge lp:~abrody/launchpad/https-mirror into lp:launchpad
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Colin Watson | ||||
Proposed branch: | lp:~abrody/launchpad/https-mirror | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
272 lines (+55/-19) 9 files modified
lib/lp/registry/browser/distributionmirror.py (+6/-5) lib/lp/registry/configure.zcml (+4/-2) lib/lp/registry/interfaces/distribution.py (+3/-3) lib/lp/registry/interfaces/distributionmirror.py (+17/-2) lib/lp/registry/model/distribution.py (+6/-3) lib/lp/registry/model/distributionmirror.py (+9/-1) lib/lp/registry/templates/distributionmirror-index.pt (+4/-0) lib/lp/registry/templates/distributionmirror-macros.pt (+3/-1) lib/lp/testing/factory.py (+3/-2) |
||||
To merge this branch: | bzr merge lp:~abrody/launchpad/https-mirror | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Needs Fixing | ||
Review via email: mp+362903@code.launchpad.net |
This proposal supersedes a proposal from 2019-02-02.
Description of the change
This branch adds functionality to track HTTPS archive/CD mirror URLs.
It adds an https_base_url field much like the existing http_base_url field to the mirror create, edit, and list views.
lp:~abrody/launchpad/https-mirror-dbchange contains the DB changes.
$ make lint
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
database/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
Unmerged revisions
- 18873. By Andy Brody
-
Add support for listing HTTPS archive/CD mirrors.
Thanks for working on this, and apologies for the delay in reviewing it.
This looks OK as far as it goes, but I'd expect some test changes as well. lib/lp/ registry/ stories/ webservice/ xx-distribution .txt and lib/lp/ registry/ stories/ webservice/ xx-distribution -mirror. txt will certainly need at least basic changes due to the newly-exported fields, and it would be good to add suitable tests to lib/lp/ registry/ browser/ tests/distribut ionmirror- views.txt and lib/lp/ registry/ doc/distributio n-mirror. txt.
Let us know if you have any difficulties running the test suite, and we can walk you through it.