Merge lp:~aacid/unity-2d/fixspreadtogglingfromlauncher into lp:unity-2d
Proposed by
Albert Astals Cid
Status: | Merged |
---|---|
Approved by: | Gerry Boland |
Approved revision: | 1023 |
Merged at revision: | 1021 |
Proposed branch: | lp:~aacid/unity-2d/fixspreadtogglingfromlauncher |
Merge into: | lp:unity-2d |
Diff against target: |
71 lines (+44/-1) 2 files modified
spread/app/spreadmanager.cpp (+1/-1) tests/spread/spread-tests.rb (+43/-0) |
To merge this branch: | bzr merge lp:~aacid/unity-2d/fixspreadtogglingfromlauncher |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gerry Boland (community) | Needs Fixing | ||
Review via email: mp+99901@code.launchpad.net |
Commit message
[spread] Make toggling the spread from the launcher work
Make the connection for onViewVisibleCh
Description of the change
Make toggling the spread from the launcher work
Make the connection for onViewVisibleCh
No idea why i need the loop to wait for the spread in the test, but otherwise weird things happen
To post a comment you must log in.
Being pedantic, you could use "pgrep" instead of
bash -c "ps -A | grep unity-2d-spread"
Please also add the bug URL to the References section. Helps explain why we have such a test, in case manual tests are done too.
Also any reason why you don't use "spreadItem.tap" instead of "spreadItem. move_mouse; XDo::Mouse.click"