Merge lp:~3v1n0/unity/quick-alt+tab-fixes into lp:unity
Status: | Merged |
---|---|
Merged at revision: | 2282 |
Proposed branch: | lp:~3v1n0/unity/quick-alt+tab-fixes |
Merge into: | lp:unity |
Diff against target: |
211 lines (+86/-38) 5 files modified
manual-tests/QuickAltTab.txt (+17/-0) plugins/unityshell/src/BamfLauncherIcon.cpp (+16/-4) plugins/unityshell/src/PluginAdapter.cpp (+44/-31) plugins/unityshell/src/SwitcherController.cpp (+8/-3) plugins/unityshell/src/WindowManager.h (+1/-0) |
To merge this branch: | bzr merge lp:~3v1n0/unity/quick-alt+tab-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Penhey (community) | Needs Information | ||
Review via email: mp+85583@code.launchpad.net |
Description of the change
Make the quick Alt+Tab more consistent.
The quick Alt+Tab should be handled in a different way according to bug #861250, so I've made it possible by making the SwitcherController to use the ActionArg button member to define the type of the switch that has been performed (I've made this not to add an extra member to the class, but this can be changed if you want the code to be more clean).
Then the activated BamfLauncherIcon redirects this information to the PluginAdapter's FocusWindowGroup that now when called with the FocusVisibility
A manual test is included.
How does this interaction work with the alt-tab switcher defaulting to only showing applications running on the same workspace? Are there any considerations we have to make there?