Merge lp:~3v1n0/unity/cairobaswindow-better-damage into lp:unity
Proposed by
Marco Trevisan (Treviño)
Status: | Merged |
---|---|
Approved by: | Christopher Townsend |
Approved revision: | no longer in the source branch. |
Merged at revision: | 3545 |
Proposed branch: | lp:~3v1n0/unity/cairobaswindow-better-damage |
Merge into: | lp:unity |
Diff against target: |
211 lines (+32/-48) 5 files modified
launcher/CairoBaseWindow.cpp (+20/-14) launcher/CairoBaseWindow.h (+6/-5) launcher/QuicklistView.cpp (+1/-14) launcher/Tooltip.cpp (+4/-9) plugins/unityshell/src/unityshell.cpp (+1/-6) |
To merge this branch: | bzr merge lp:~3v1n0/unity/cairobaswindow-better-damage |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christopher Townsend | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email: mp+188302@code.launchpad.net |
Commit message
CairoBaseWindow: only regenerate blur texture when visible and damaged
Description of the change
Recent support to active-blur on tooltips and quicklists lead to a problem that caused the blur texture to be regenerated at every redraw. This is actually not needed and may also cause slow-downs (especially during fade-in/fade-out). We should instead generate it only when showing the window and when the area is damaged.
To post a comment you must log in.
PASSED: Continuous integration, rev:3541 jenkins. qa.ubuntu. com/job/ unity-ci/ 405/ jenkins. qa.ubuntu. com/job/ unity-saucy- amd64-ci/ 294 jenkins. qa.ubuntu. com/job/ unity-saucy- armhf-ci/ 292 jenkins. qa.ubuntu. com/job/ unity-saucy- i386-ci/ 293
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ unity-ci/ 405/rebuild
http://