Merge ~3v1n0/ubuntu/+source/nautilus:ubuntu/bionic into ~ubuntu-desktop/ubuntu/+source/nautilus:ubuntu/bionic

Proposed by Marco Trevisan (Treviño)
Status: Merged
Merged at revision: 2900d5082ba2c79f01b8d78d43677e01a779e778
Proposed branch: ~3v1n0/ubuntu/+source/nautilus:ubuntu/bionic
Merge into: ~ubuntu-desktop/ubuntu/+source/nautilus:ubuntu/bionic
Diff against target: 74 lines (+18/-8)
2 files modified
debian/changelog (+8/-0)
debian/patches/0015-tracker-search-engine-don-t-start-it-if-not-availabl.patch (+10/-8)
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
git-ubuntu developers Pending
Review via email: mp+374710@code.launchpad.net

This proposal supersedes a proposal from 2019-10-25.

Commit message

Sync VCS with packaging

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 17553e8..ad6d1f5 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
1nautilus (1:3.26.4-0~ubuntu18.04.4) bionic; urgency=medium
2
3 * d/p/0015-tracker-search-engine-don-t-start-it-if-not-availabl.patch:
4 - update the patch to fix a logic error in the code which made tracker
5 never being used even if it's installed (lp: #1767817)
6
7 -- Sebastien Bacher <seb128@ubuntu.com> Wed, 06 Mar 2019 17:31:08 +0100
8
1nautilus (1:3.26.4-0~ubuntu18.04.3) bionic; urgency=medium9nautilus (1:3.26.4-0~ubuntu18.04.3) bionic; urgency=medium
210
3 * debian/patches/git_captions_order.patch11 * debian/patches/git_captions_order.patch
diff --git a/debian/patches/0015-tracker-search-engine-don-t-start-it-if-not-availabl.patch b/debian/patches/0015-tracker-search-engine-don-t-start-it-if-not-availabl.patch
index 4cc55ed..d24e83c 100644
--- a/debian/patches/0015-tracker-search-engine-don-t-start-it-if-not-availabl.patch
+++ b/debian/patches/0015-tracker-search-engine-don-t-start-it-if-not-availabl.patch
@@ -6,10 +6,10 @@ Subject: tracker-search-engine: don't start it if not available on system
6 src/nautilus-search-engine-tracker.c | 24 ++++++++++++++++++++----6 src/nautilus-search-engine-tracker.c | 24 ++++++++++++++++++++----
7 1 file changed, 20 insertions(+), 4 deletions(-)7 1 file changed, 20 insertions(+), 4 deletions(-)
88
9diff --git a/src/nautilus-search-engine-tracker.c b/src/nautilus-search-engine-tracker.c9Index: nautilus-3.26.4/src/nautilus-search-engine-tracker.c
10index 8885ca4..050716d 10064410===================================================================
11--- a/src/nautilus-search-engine-tracker.c11--- nautilus-3.26.4.orig/src/nautilus-search-engine-tracker.c
12+++ b/src/nautilus-search-engine-tracker.c12+++ nautilus-3.26.4/src/nautilus-search-engine-tracker.c
13@@ -42,6 +42,7 @@ struct _NautilusSearchEngineTracker13@@ -42,6 +42,7 @@ struct _NautilusSearchEngineTracker
14 gboolean query_pending;14 gboolean query_pending;
15 GQueue *hits_pending;15 GQueue *hits_pending;
@@ -18,7 +18,7 @@ index 8885ca4..050716d 100644
18 gboolean recursive;18 gboolean recursive;
19 gboolean fts_enabled;19 gboolean fts_enabled;
20 20
21@@ -304,8 +305,15 @@ nautilus_search_engine_tracker_start (NautilusSearchProvider *provider)21@@ -304,8 +305,15 @@ nautilus_search_engine_tracker_start (Na
22 return;22 return;
23 }23 }
24 24
@@ -35,7 +35,7 @@ index 8885ca4..050716d 100644
35 tracker->query_pending = TRUE;35 tracker->query_pending = TRUE;
36 36
37 g_object_notify (G_OBJECT (provider), "running");37 g_object_notify (G_OBJECT (provider), "running");
38@@ -471,6 +479,9 @@ nautilus_search_engine_tracker_set_query (NautilusSearchProvider *provider,38@@ -471,6 +479,9 @@ nautilus_search_engine_tracker_set_query
39 39
40 g_clear_object (&tracker->query);40 g_clear_object (&tracker->query);
41 41
@@ -45,7 +45,7 @@ index 8885ca4..050716d 100644
45 tracker->query = g_object_ref (query);45 tracker->query = g_object_ref (query);
46 tracker->recursive = is_recursive_search (NAUTILUS_SEARCH_ENGINE_TYPE_INDEXED,46 tracker->recursive = is_recursive_search (NAUTILUS_SEARCH_ENGINE_TYPE_INDEXED,
47 nautilus_query_get_recursive (query),47 nautilus_query_get_recursive (query),
48@@ -539,16 +550,21 @@ static void48@@ -539,16 +550,23 @@ static void
49 nautilus_search_engine_tracker_init (NautilusSearchEngineTracker *engine)49 nautilus_search_engine_tracker_init (NautilusSearchEngineTracker *engine)
50 {50 {
51 GError *error = NULL;51 GError *error = NULL;
@@ -54,8 +54,10 @@ index 8885ca4..050716d 100644
54- engine->hits_pending = g_queue_new ();54- engine->hits_pending = g_queue_new ();
55-55-
56- engine->connection = tracker_sparql_connection_get (NULL, &error);56- engine->connection = tracker_sparql_connection_get (NULL, &error);
57+ if (!tracker_available)57+ if (tracker_available)
58+ engine->connection = tracker_sparql_connection_get (NULL, &error);58+ engine->connection = tracker_sparql_connection_get (NULL, &error);
59+ else
60+ return;
59 61
60 if (error)62 if (error)
61 {63 {

Subscribers

People subscribed via source and target branches