Merge lp:~3v1n0/ubuntu-themes/appmenu-theming-shape-fix into lp:ubuntu-themes

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 552
Merged at revision: 557
Proposed branch: lp:~3v1n0/ubuntu-themes/appmenu-theming-shape-fix
Merge into: lp:ubuntu-themes
Prerequisite: lp:~3v1n0/ubuntu-themes/radiance-headerbar-buttons-fix
Diff against target: 57 lines (+32/-4)
2 files modified
Ambiance/gtk-3.20/gtk-widgets.css (+16/-2)
Radiance/gtk-3.20/gtk-widgets.css (+16/-2)
To merge this branch: bzr merge lp:~3v1n0/ubuntu-themes/appmenu-theming-shape-fix
Reviewer Review Type Date Requested Status
Dmitry Shachnev Approve
Review via email: mp+324517@code.launchpad.net

Commit message

Ambiance, Radiance: ignore titlebutton theming for appmenu

To post a comment you must log in.
552. By Marco Trevisan (Treviño)

Ambiance, Radiance: reduce opacity of the appmenu button on active and checked state

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

This removes the ugly circle, thanks! I was originally thinking of a proper rectangle button, but this also looks nice.

review: Approve
Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

I think some hover effect also would be nice, but this is definitely better. :) Thanks!

Revision history for this message
Adolfo Jayme Barrientos (fitojb) wrote :

Is anything blocking the merging of this patch?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Ambiance/gtk-3.20/gtk-widgets.css'
--- Ambiance/gtk-3.20/gtk-widgets.css 2017-05-18 16:14:20 +0000
+++ Ambiance/gtk-3.20/gtk-widgets.css 2017-05-24 05:34:05 +0000
@@ -2151,8 +2151,22 @@
2151 background-image: linear-gradient(to top, #605f59, #5b5a54);2151 background-image: linear-gradient(to top, #605f59, #5b5a54);
2152}2152}
21532153
21542154.titlebar button.titlebutton.appmenu,
21552155.titlebar button.titlebutton.appmenu:backdrop {
2156 border: none;
2157 background-image: none;
2158 color: transparent;
2159 background-color: transparent;
2160}
2161
2162.titlebar button.titlebutton.appmenu:checked,
2163.titlebar button.titlebutton.appmenu:active {
2164 opacity: 0.75;
2165}
2166
2167.titlebar button.titlebutton.appmenu:backdrop {
2168 opacity: 0.5;
2169}
21562170
2157/***********2171/***********
2158 * toolbar *2172 * toolbar *
21592173
=== modified file 'Radiance/gtk-3.20/gtk-widgets.css'
--- Radiance/gtk-3.20/gtk-widgets.css 2017-05-24 05:34:05 +0000
+++ Radiance/gtk-3.20/gtk-widgets.css 2017-05-24 05:34:05 +0000
@@ -2154,8 +2154,22 @@
2154 background-image: linear-gradient(to top, #ece9e6, #e8e4e1);2154 background-image: linear-gradient(to top, #ece9e6, #e8e4e1);
2155}2155}
21562156
21572157.titlebar button.titlebutton.appmenu,
21582158.titlebar button.titlebutton.appmenu:backdrop {
2159 border: none;
2160 background-image: none;
2161 color: transparent;
2162 background-color: transparent;
2163}
2164
2165.titlebar button.titlebutton.appmenu:checked,
2166.titlebar button.titlebutton.appmenu:active {
2167 opacity: 0.75;
2168}
2169
2170.titlebar button.titlebutton.appmenu:backdrop {
2171 opacity: 0.5;
2172}
21592173
2160/***********2174/***********
2161 * toolbar *2175 * toolbar *

Subscribers

People subscribed via source and target branches