Merge lp:~3v1n0/nautilus/ubuntu-unity-launcher-support into lp:~ubuntu-desktop/nautilus/ubuntu
Status: | Merged |
---|---|
Merged at revision: | 169 |
Proposed branch: | lp:~3v1n0/nautilus/ubuntu-unity-launcher-support |
Merge into: | lp:~ubuntu-desktop/nautilus/ubuntu |
Diff against target: |
216 lines (+57/-32) 5 files modified
debian/changelog (+12/-0) debian/control (+3/-2) debian/patches/11_copy_skipping_pager.patch (+4/-4) debian/patches/12_unity_launcher_support.patch (+37/-26) debian/rules (+1/-0) |
To merge this branch: | bzr merge lp:~3v1n0/nautilus/ubuntu-unity-launcher-support |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Didier Roche-Tolomelli | Approve | ||
Sebastien Bacher | Pending | ||
Review via email: mp+74401@code.launchpad.net |
Description of the change
Here I'm mostly fixing the bug #841609 caused by a division per zero which lead to a bad unity launcher progressbar rendering. Plus I've improved a little the unity support code with some improvements described in the changelog.
Also, as requested in the merge proposal [1] for the branch lp:~3v1n0/ubuntu/oneiric/nautilus/progress-indicator-support I've disabled the indicator support using the --disable-
Of course that can be done also removing the related patch, but I'd keep there until it won't be outdated.
[1] https:/
PS: Previous merge request at https:/
Thanks a lot for your patch, looks good and works well :)
Some note I fixed before sponsoring:
- can you please ensure that you list everything you did in the packaging in the changelog (like the additional build-dep)
- also, we tend to keep "UNRELEASED" until the sponsor set to "oneiric" if there are more than one pending change by upload.
But that's really minor, thanks again for your work there. Sponsoring.