Merge lp:~3v1n0/indicator-appmenu/per-window-showmenu+leak-fix into lp:indicator-appmenu/15.10

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Andrea Azzarone
Approved revision: no longer in the source branch.
Merged at revision: 273
Proposed branch: lp:~3v1n0/indicator-appmenu/per-window-showmenu+leak-fix
Merge into: lp:indicator-appmenu/15.10
Diff against target: 23 lines (+5/-6)
1 file modified
src/indicator-appmenu.c (+5/-6)
To merge this branch: bzr merge lp:~3v1n0/indicator-appmenu/per-window-showmenu+leak-fix
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Andrea Azzarone (community) Approve
Review via email: mp+273105@code.launchpad.net

Commit message

IndicatorAppmenu: only emit snow-now-changed signal for menus belonging to the window that requested

Also fix a memory leak we had (entries list had to be free'd)

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) :
review: Approve
276. By Marco Trevisan (Treviño)

IndicatorAppmenu: only emit snow-now-changed signal for menus belonging to the window that requested

Also fix a memory leak we had (entries list had to be free'd)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/indicator-appmenu.c'
--- src/indicator-appmenu.c 2015-06-01 17:44:58 +0000
+++ src/indicator-appmenu.c 2015-10-01 17:03:40 +0000
@@ -1371,14 +1371,13 @@
1371window_status_changed (WindowMenu * mw, DbusmenuStatus status, IndicatorAppmenu * iapp)1371window_status_changed (WindowMenu * mw, DbusmenuStatus status, IndicatorAppmenu * iapp)
1372{1372{
1373 gboolean show_now = (status == DBUSMENU_STATUS_NOTICE);1373 gboolean show_now = (status == DBUSMENU_STATUS_NOTICE);
1374 GList * entry_head, * entries;1374 GList * l, * window_entries = window_menu_get_entries(mw);
13751375
1376 entry_head = indicator_object_get_entries(INDICATOR_OBJECT(iapp));1376 for (l = window_entries; l; l = l->next) {
13771377 IndicatorObjectEntry * entry = l->data;
1378 for (entries = entry_head; entries != NULL; entries = g_list_next(entries)) {
1379 IndicatorObjectEntry * entry = (IndicatorObjectEntry *)entries->data;
1380 g_signal_emit(G_OBJECT(iapp), INDICATOR_OBJECT_SIGNAL_SHOW_NOW_CHANGED_ID, 0, entry, show_now);1378 g_signal_emit(G_OBJECT(iapp), INDICATOR_OBJECT_SIGNAL_SHOW_NOW_CHANGED_ID, 0, entry, show_now);
1381 }1379 }
1380 g_list_free (window_entries);
1382}1381}
13831382
1384/* Pass up the show menu event */1383/* Pass up the show menu event */

Subscribers

People subscribed via source and target branches