Merge lp:~tvansteenburgh/charms/precise/openstack-dashboard/fix-tests into lp:~openstack-charmers-archive/charms/precise/openstack-dashboard/trunk

Proposed by Tim Van Steenburgh
Status: Merged
Merge reported by: James Page
Merged at revision: not available
Proposed branch: lp:~tvansteenburgh/charms/precise/openstack-dashboard/fix-tests
Merge into: lp:~openstack-charmers-archive/charms/precise/openstack-dashboard/trunk
Diff against target: 57 lines (+14/-2)
2 files modified
Makefile (+10/-2)
config.yaml (+4/-0)
To merge this branch: bzr merge lp:~tvansteenburgh/charms/precise/openstack-dashboard/fix-tests
Reviewer Review Type Date Requested Status
James Page Approve
Review via email: mp+234238@code.launchpad.net

Description of the change

Fix tests, proofs.

To post a comment you must log in.
Revision history for this message
James Page (james-page) wrote :

defaults fixed in next; postponing virtualenv use until we have a broader team discussion.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2014-05-21 10:15:35 +0000
3+++ Makefile 2014-09-11 01:22:32 +0000
4@@ -5,9 +5,14 @@
5 @flake8 --exclude hooks/charmhelpers hooks unit_tests
6 @charm proof
7
8-test:
9+test: .venv
10 @echo Starting tests...
11- @$(PYTHON) /usr/bin/nosetests --nologcapture unit_tests
12+ .venv/bin/nosetests --nologcapture unit_tests
13+
14+.venv:
15+ sudo apt-get install -y python-virtualenv python-apt
16+ virtualenv .venv --system-site-packages
17+ .venv/bin/pip install -I nose mock pyyaml
18
19 sync:
20 @charm-helper-sync -c charm-helpers-sync.yaml
21@@ -15,3 +20,6 @@
22 publish: lint test
23 bzr push lp:charms/openstack-dashboard
24 bzr push lp:charms/trusty/openstack-dashboard
25+
26+clean:
27+ rm -rf .venv
28
29=== modified file 'config.yaml'
30--- config.yaml 2014-02-03 12:34:56 +0000
31+++ config.yaml 2014-09-11 01:22:32 +0000
32@@ -35,6 +35,7 @@
33 vip:
34 type: string
35 description: "Virtual IP to use to front openstack dashboard ha configuration"
36+ default:
37 vip_iface:
38 type: string
39 default: eth0
40@@ -68,10 +69,12 @@
41 Swifts's entry in the Keystone catalog to use https, and override
42 any certficiate and key issued by Keystone (if it is configured to
43 do so).
44+ default:
45 ssl_key:
46 type: string
47 description: |
48 Base64 encoded SSL key to use with certificate specified as ssl_cert.
49+ default:
50 offline-compression:
51 type: string
52 default: "yes"
53@@ -87,3 +90,4 @@
54 secret:
55 type: string
56 description: Secret for Horizon to use when securing internal data; set this when using multiple dashboard units.
57+ default:

Subscribers

People subscribed via source and target branches