Merge lp:~tribaal/simplestreams/fix-lxd-image-types into lp:simplestreams

[Chris Glass]

This branch adds the image format used by cloud-images.ubuntu.com to the LXD type (use when the configuration specifies "hypervisor_mapping" as non-null (what the lib considers "True").

Example for xenial: http://cloud-images.ubuntu.com/xenial/current/xenial-server-cloudimg-amd64-lxd.tar.xz

[Данило Шеган (danilo)]

LGTM.

review: Approve

[Scott Moser (smoser)]

chris pinged me in irc, so i'll just replay that here:

<tribaal> smoser: basically just adds the lxd image format the archives actually use to the LXD images types whitelist
--- msbrown is now known as msbrown-afk
<smoser> tribaal, but is that right ?
<smoser> the lxd.tar.xz file is not actually useful
<smoser> it is not actually consumable by openstack (or nova-lxd)
<smoser> to my knowledge

if the lxd.tar.xz is not useful, then there is no reason to ever load it into glance.

[Ryan Beisner (1chb1n)]

For reference, here is the "manual" process we use to get LXD images into OpenStack for use with nova-lxd:

http://bazaar.launchpad.net/~ost-maintainers/openstack-charm-testing/trunk/view/head:/tools/images_lxd.sh

This allows one to successfully nova boot those images as lxd instances, given that there is such a hypervisor in said cloud.

[Scott Moser (smoser)]

So Ryan's comment above shows that they use the -root.tar.xz, *not* the -lxd.tar.xz.
Ryan's command does:
glance --os-image-api-version 1 image-create --name="trusty-lxd" --is-public=true --progress \
    --container-format=bare --disk-format=raw --property hypervisor_type=lxc \
    --property architecture=x86_64 < ~/images/trusty-server-cloudimg-amd64-root.tar.xz

For lxc type, it looks like we set:
  container_format: bare
  disk_format: root-tar
  architecture: x86_64

The one thing that looks different is glance mirror would set disk_format to 'root-tar', while Ryan is setting it to 'raw'. root-tar seems much closer to 'correct', but that doesn't matter a darn if its not what nova-lxd wants.

[Scott Moser (smoser)]

I'm marking this as 'rejected'.
Please feel free to re-open if you think that is not right.

Unmerged revisions

438. By Chris Glass on 2016-07-11

Added the "lxd.tar.xz" type as a LXD hypervisor format for disk images.
The ubuntu archives (cloud-images.ubuntu.com) actually use that format for lxd.

=== modified file 'simplestreams/mirrors/glance.py'
--- simplestreams/mirrors/glance.py	2016-06-14 20:21:05 +0000
+++ simplestreams/mirrors/glance.py	2016-07-11 07:19:08 +0000
@@ -65,6 +65,7 @@
 LXC_FTYPES = [
     'root.tar.gz',
     'root.tar.xz',
+    'lxd.tar.xz',
 ]
 
 QEMU_FTYPES = [