Merge lp:~timkuhlman/charms/trusty/rsyslog-forwarder-ha/deps into lp:charms/trusty/rsyslog-forwarder-ha

Proposed by Tim Kuhlman
Status: Merged
Merged at revision: 15
Proposed branch: lp:~timkuhlman/charms/trusty/rsyslog-forwarder-ha/deps
Merge into: lp:charms/trusty/rsyslog-forwarder-ha
Diff against target: 25 lines (+11/-0)
2 files modified
hooks/hooks.py (+2/-0)
hooks/install (+9/-0)
To merge this branch: bzr merge lp:~timkuhlman/charms/trusty/rsyslog-forwarder-ha/deps
Reviewer Review Type Date Requested Status
Review Queue (community) automated testing Needs Fixing
Stuart Bishop (community) Approve
Review via email: mp+295891@code.launchpad.net

Description of the change

Explicitly install the dependencies for this package. I found this was needed for xenial as the package this is subordinate to moved to using python3 and so didn't install these anymore for python2.

To post a comment you must log in.
Revision history for this message
Stuart Bishop (stub) wrote :

Looks good

review: Approve
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/4407/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/4427/

review: Needs Fixing (automated testing)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/hooks.py'
2--- hooks/hooks.py 2016-03-30 22:10:17 +0000
3+++ hooks/hooks.py 2016-05-26 22:35:24 +0000
4@@ -202,4 +202,6 @@
5
6
7 if __name__ == "__main__":
8+ if sys.argv[0].split('/')[-1] == 'hooks.py':
9+ del sys.argv[0]
10 hooks.execute(sys.argv)
11
12=== modified symlink 'hooks/install' (properties changed: -x to +x)
13=== target was u'hooks.py'
14--- hooks/install 1970-01-01 00:00:00 +0000
15+++ hooks/install 2016-05-26 22:35:24 +0000
16@@ -0,0 +1,9 @@
17+#!/bin/sh
18+
19+set -eu
20+
21+juju-log 'Ensuring dependencies are installed'
22+apt-get install -y python python-apt python-yaml python-sqlalchemy
23+
24+juju-log 'Invoking python-based install hook'
25+python hooks/hooks.py install

Subscribers

People subscribed via source and target branches