Merge lp:~teknico/charms/precise/keystone/add-valid-service into lp:~openstack-charmers-archive/charms/precise/keystone/trunk

Proposed by Marco Ceppi
Status: Work in progress
Proposed branch: lp:~teknico/charms/precise/keystone/add-valid-service
Merge into: lp:~openstack-charmers-archive/charms/precise/keystone/trunk
Diff against target: 24 lines (+4/-4)
1 file modified
hooks/keystone_hooks.py (+4/-4)
To merge this branch: bzr merge lp:~teknico/charms/precise/keystone/add-valid-service
Reviewer Review Type Date Requested Status
Marco Ceppi Pending
James Page Pending
Review via email: mp+207163@code.launchpad.net

This proposal supersedes a proposal from 2014-02-06.

Description of the change

An entry for the simplestreams-mirror service is added to the valid_services structure in keystone_hooks.py .

The simplestreams-mirror charm that needs this can be found at https://code.launchpad.net/~teknico/charms/precise/simplestreams-mirror/trunk .

To post a comment you must log in.
Revision history for this message
Marco Ceppi (marcoceppi) wrote : Posted in a previous version of this proposal

Deferring to openstack-charmers

review: Abstain
Revision history for this message
James Page (james-page) wrote : Posted in a previous version of this proposal

On the assumption that this is intended for tools like juju to consume, the name and type of the service needs to be 'product-streams' not 'simplestreams-mirror' - please double check this with the juju-core team to ensure that catalog lookups will work OK.

review: Needs Fixing
Revision history for this message
James Page (james-page) wrote : Posted in a previous version of this proposal

We can also drop:

    "oxygen": {
        "type": "oxygen",
        "desc": "Oxygen Cloud Image Service"
    },

This was a pre-cursor to simplestreams.

Unmerged revisions

57. By Nicola Larosa

The type too.

56. By Nicola Larosa

Updates per James Page's review.

55. By Nicola Larosa

Merge from trunk.

54. By Nicola Larosa

Add to valid_services and entry for simplestreams-mirror.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/keystone_hooks.py'
2--- hooks/keystone_hooks.py 2014-02-03 11:58:43 +0000
3+++ hooks/keystone_hooks.py 2014-02-19 12:35:54 +0000
4@@ -88,10 +88,6 @@
5 "type": "network",
6 "desc": "Quantum Networking Service"
7 },
8- "oxygen": {
9- "type": "oxygen",
10- "desc": "Oxygen Cloud Image Service"
11- },
12 "ceilometer": {
13 "type": "metering",
14 "desc": "Ceilometer Metering Service"
15@@ -103,6 +99,10 @@
16 "heat-cfn": {
17 "type": "cloudformation",
18 "desc": "Heat CloudFormation API"
19+ },
20+ "product-streams": {
21+ "type": "product-streams",
22+ "desc": "Product caching using Simplestreams"
23 }
24 }
25

Subscribers

People subscribed via source and target branches