Merge lp:~submarine/unity-scope-googlenews/surfacing into lp:unity-scope-googlenews

Proposed by David Callé
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 65
Merged at revision: 65
Proposed branch: lp:~submarine/unity-scope-googlenews/surfacing
Merge into: lp:unity-scope-googlenews
Diff against target: 17 lines (+2/-3)
1 file modified
src/unity_googlenews_daemon.py (+2/-3)
To merge this branch: bzr merge lp:~submarine/unity-scope-googlenews/surfacing
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+166192@code.launchpad.net

Commit message

Surface news on empty queries

Description of the change

This change allows top and local news to appear on empty queries (eg "news:")

NB. local news are currently broken on Google side (http://productforums.google.com/forum/#!topic/news/KAyzq081urA)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Paweł Stołowski (stolowski) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/unity_googlenews_daemon.py'
2--- src/unity_googlenews_daemon.py 2013-05-22 20:44:23 +0000
3+++ src/unity_googlenews_daemon.py 2013-05-29 08:28:50 +0000
4@@ -113,11 +113,10 @@
5 global country, city
6 if country is None:
7 country, city = get_location()
8-
9 results = []
10- if not search or len(search) <= 2:
11- return results
12 if search:
13+ if len(search) < 3:
14+ return results
15 search = urllib.parse.quote(search)
16 for cat in range(0,2):
17 topic = ''

Subscribers

People subscribed via source and target branches

to all changes: