Unity Google News Scope

Merge lp:~submarine/unity-scope-googlenews/fallback-result-icon into lp:unity-scope-googlenews

  1. fallback-result-icon
  2. Merge into trunk
Proposed by David Callé
Status: Merged
Approved by: Francis Ginther
Approved revision: 67
Merged at revision: 68
Proposed branch: lp:~submarine/unity-scope-googlenews/fallback-result-icon
Merge into: lp:unity-scope-googlenews
Diff against target: 11 lines (+1/-1)
1 file modified
src/unity_googlenews_daemon.py (+1/-1)
To merge this branch: bzr merge lp:~submarine/unity-scope-googlenews/fallback-result-icon
Reviewer Review Type Date Requested Status
David Callé Approve
PS Jenkins bot (community) continuous-integration Approve
Michal Hruby (community) Approve
Review via email: mp+167761@code.launchpad.net

Commit message

Change fallback result icon

Description of the change

Use a fallback result icon that actually exists.
http://ubuntuone.com/7ewCXRPmXJQGTiyck2X8qK

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

Looks fine. +1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-scope-googlenews-autolanding/7/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/generic-cleanup-mbs/152
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-googlenews-saucy-amd64-autolanding/1/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-googlenews-saucy-armhf-autolanding/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-googlenews-saucy-i386-autolanding/1

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:67
http://jenkins.qa.ubuntu.com/job/unity-scope-googlenews-ci/8/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-googlenews-saucy-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-googlenews-saucy-armhf-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-googlenews-saucy-i386-ci/1

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-googlenews-ci/8/rebuild

review: Approve (continuous-integration)
Revision history for this message
David Callé (davidc3) wrote :

Jenkins, ping :)

review: Approve
Revision history for this message
Francis Ginther (fginther) wrote :

Autolanding failed due a launchpad connection issue, retrying.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/unity_googlenews_daemon.py'
2--- src/unity_googlenews_daemon.py 2013-05-29 08:22:17 +0000
3+++ src/unity_googlenews_daemon.py 2013-06-06 13:53:28 +0000
4@@ -43,7 +43,7 @@
5 PROVIDER_CREDITS = _('Powered by Google News')
6 SVG_DIR = '/usr/share/icons/unity-icon-theme/places/svg/'
7 PROVIDER_ICON = SVG_DIR+'service-googlenews.svg'
8-DEFAULT_RESULT_ICON = SVG_DIR+'result-news.svg'
9+DEFAULT_RESULT_ICON = SVG_DIR+'group-news.svg'
10 DEFAULT_RESULT_MIMETYPE = 'text/html'
11 DEFAULT_RESULT_TYPE = Unity.ResultType.DEFAULT
12

Subscribers

People subscribed via source and target branches

to all changes: