Merge lp:~stylesen/lava-scheduler/board-unit-test-fix into lp:lava-scheduler/multinode

Proposed by Senthil Kumaran S
Status: Merged
Approved by: Neil Williams
Approved revision: 277
Merged at revision: 281
Proposed branch: lp:~stylesen/lava-scheduler/board-unit-test-fix
Merge into: lp:lava-scheduler/multinode
Diff against target: 11 lines (+1/-1)
1 file modified
lava_scheduler_daemon/board.py (+1/-1)
To merge this branch: bzr merge lp:~stylesen/lava-scheduler/board-unit-test-fix
Reviewer Review Type Date Requested Status
Neil Williams Approve
Review via email: mp+180833@code.launchpad.net

Description of the change

Fix board based unit tests for lava scheduler daemon. This shows the backward compatibilty of lava-scheduler-daemon with the board based scheduler.

To post a comment you must log in.
Revision history for this message
Neil Williams (codehelp) wrote :

Tested on multinode.v.l.o:
(multinode)instance-manager@multinode:/home/codehelp/lava-scheduler/lava_scheduler_daemon/tests$ trial test_board.py
Ran 11 tests in 0.023s

PASSED (successes=11)

Approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lava_scheduler_daemon/board.py'
2--- lava_scheduler_daemon/board.py 2013-07-17 12:48:53 +0000
3+++ lava_scheduler_daemon/board.py 2013-08-19 10:49:00 +0000
4@@ -339,7 +339,7 @@
5 self.logger.info("starting job %r", job_data)
6 self.running_job = self.job_cls(
7 job_data, self.dispatcher, self.source, self.board_name,
8- self.reactor, self.daemon_options)
9+ self.reactor, self.daemon_options, None)
10 d = self.running_job.run()
11 d.addCallbacks(self._cbJobFinished, self._ebJobFinished)
12

Subscribers

People subscribed via source and target branches

to status/vote changes: