Merge lp:~smoser/software-properties/trunk.lp1670399 into lp:software-properties

Proposed by Scott Moser
Status: Merged
Merge reported by: Scott Moser
Merged at revision: not available
Proposed branch: lp:~smoser/software-properties/trunk.lp1670399
Merge into: lp:software-properties
Diff against target: 44 lines (+9/-5)
3 files modified
debian/tests/control (+1/-1)
debian/tests/run-tests (+7/-3)
softwareproperties/shortcuts.py (+1/-1)
To merge this branch: bzr merge lp:~smoser/software-properties/trunk.lp1670399
Reviewer Review Type Date Requested Status
Ubuntu Core Development Team Pending
Review via email: mp+319105@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/tests/control'
2--- debian/tests/control 2016-09-01 10:23:19 +0000
3+++ debian/tests/control 2017-03-06 17:11:16 +0000
4@@ -1,5 +1,5 @@
5 Tests: run-tests
6-Depends: @, xvfb, dbus-x11, python-dbus, python-pycurl, python3-pycurl, python-mock, python3-mock, python-distutils-extra, python-setuptools, python3-distutils-extra, python3-setuptools, python-gi, python3-gi, pyflakes, pyflakes3
7+Depends: @, xvfb, dbus-x11, python-dbus, python-pycurl, python3-pycurl, python-mock, python3-mock, python-distutils-extra, python-setuptools, python3-distutils-extra, python3-setuptools, python-gi, python3-gi, pyflakes, pyflakes3, gnupg
8
9 Tests: add-apt-repository
10 Depends: software-properties-common, gnupg
11
12=== modified file 'debian/tests/run-tests'
13--- debian/tests/run-tests 2016-09-12 11:49:08 +0000
14+++ debian/tests/run-tests 2017-03-06 17:11:16 +0000
15@@ -14,9 +14,13 @@
16 export LC_ALL=C.UTF-8
17
18 # dirmngr and/or gpg-agent fail without ~/.gnupg present maybe some
19-# places should be properly declaring homedir, instead of just
20-# keyrings
21-gpg1 -k >/dev/null 2>&1
22+# places should be properly declaring homedir, instead of just keyrings
23+if ! out=$(gpg --list-keys 2>&1); then
24+ ret=$?
25+ echo "Failed [$ret] to initialize ~/.gnupg with: gpg --list-keys" 1>&2
26+ echo "$out" 1>&2;
27+ exit $ret
28+fi
29
30 code=0
31 if [ "$TMPDIR" ]; then
32
33=== modified file 'softwareproperties/shortcuts.py'
34--- softwareproperties/shortcuts.py 2014-09-24 09:50:37 +0000
35+++ softwareproperties/shortcuts.py 2017-03-06 17:11:16 +0000
36@@ -31,7 +31,7 @@
37 self.shortcut = shortcut
38
39 def add_key(self, keyserver=None):
40- return None
41+ return True
42
43 def expand(self, codename=None, distro=None):
44 return (self.shortcut, None)

Subscribers

People subscribed via source and target branches

to status/vote changes: